svn commit: r901494 - in /jakarta/jmeter/trunk/src: core/org/apache/jmeter/engine/util/ core/org/apache/jmeter/functions/gui/ functions/org/apache/jmeter/functions/ protocol/jdbc/org/apache/jmeter/protocol/jdbc/sampler/

Author: sebb
Date: Thu Jan 21 01:34:10 2010
New Revision: 901494

URL: http://svn.apache.org/viewvc?rev=901494&view=rev
Log:
Document thread safety

Modified:
    jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/util/CompoundVariable.java
    jakarta/jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java
    jakarta/jmeter/trunk/src/functions/org/apache/jmeter/functions/TimeFunction.java
    jakarta/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/sampler/JDBCSampler.java

Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/util/CompoundVariable.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/util/CompoundVariable.java?rev=901494&r1=901493&r2=901494&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/util/CompoundVariable.java (original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/util/CompoundVariable.java Thu Jan 21 01:34:10 2010
@@ -47,6 +47,7 @@
 
     private static final FunctionParser functionParser = new FunctionParser();
 
+    // Created during class init; not modified thereafter 
     private static final Map<String, Class<? extends Function>> functions =
         new HashMap<String, Class<? extends Function>>();
 

Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java?rev=901494&r1=901493&r2=901494&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java (original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java Thu Jan 21 01:34:10 2010
@@ -55,6 +55,7 @@
 
     private JLabeledTextField cutPasteFunction;
 
+    // Not modified after initial setup
     private final Map<String, Class<?>> functionMap = new HashMap<String, Class<?>>();
 
     private JButton generateButton;

Modified: jakarta/jmeter/trunk/src/functions/org/apache/jmeter/functions/TimeFunction.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/functions/org/apache/jmeter/functions/TimeFunction.java?rev=901494&r1=901493&r2=901494&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/functions/org/apache/jmeter/functions/TimeFunction.java (original)
+++ jakarta/jmeter/trunk/src/functions/org/apache/jmeter/functions/TimeFunction.java Thu Jan 21 01:34:10 2010
@@ -43,6 +43,7 @@
 
     private static final List<String> desc = new LinkedList<String>();
 
+    // Only modified in class init
     private static final Map<String, String> aliases = new HashMap<String, String>();
 
     static {

Modified: jakarta/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/sampler/JDBCSampler.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/sampler/JDBCSampler.java?rev=901494&r1=901493&r2=901494&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/sampler/JDBCSampler.java (original)
+++ jakarta/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/sampler/JDBCSampler.java Thu Jan 21 01:34:10 2010
@@ -78,7 +78,8 @@
 
     // key: name (lowercase) from java.sql.Types; entry: corresponding int value
     private static final Map<String, Integer> mapJdbcNameToInt;
-
+    // read-only after class init
+    
     static {
         // based on e291. Getting the Name of a JDBC Type from javaalmanac.com
         // http://javaalmanac.com/egs/java.sql/JdbcInt2Str.html