Re: [VOTE] Release Log4j 2.25.4
"Piotr P. Karwasz" <[email protected]> Wed, 25 Mar 2026 14:00:59 +0100
| Newsgroups | gmane.comp.jakarta.log4j.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Gary, On 25.03.2026 12:50, Gary Gregory wrote: > Does that mean all the RAT check failures about missing license headers are > incorrect? I haven't checked all of them, but we have our own RAT check that uses the *same* tool and it didn't find any problems. Our `pom.xml` file have a list of exclusions, which the ATR check ignores. Among the problems found by ATR: - We intentionally exclude changelog entries: these are very short files. Adding 17 lines of ASF license causes a lot of merge conflicts, because for Git all the entries become similar enough. Reducing merge conflicts was exactly the purpose of splitting changelog entries into separate files. - It marks a couple of `*.json` files, which by their nature can not contain comments. - It marks a couple of `*.log` files used in tests, which need to be excluded. Piotr