Re: Integer.MAX_VALUE sentinel never checked?

Wow, I think we finally found evidence of time travel!

And Doug has somehow also found a way to live forever!

Mike McCandless

http://blog.mikemccandless.com


On Fri, Aug 29, 2025 at 12:27 PM Uwe Schindler <[email protected]> wrote:

> Some message from the future? 3203/12/01 ---- or does it come from the far
> past? At least no longer relevant, we left TermEnum and TermPositions
> classes behind after Lucene 3 :-)
> Am 29.08.2025 um 02:06 schrieb Bob S:
>
>
>
> On 3203/12/01 19:23:01 Doug Cutting wrote:
> > I don't think this value actually find its way into the results.  Rather
> > it causes PhraseScorer.score() to exit, as this value is always greater
> > than the value of 'end' passed into that method.
> >
> > Doug
> >
> > Simon Cozens wrote:
> >
> > > Plucene is nearly finished, and is busy being unit-tested to death. In
> the
> > > process of doing this, we found that some of our phrase queries were
> returning
> > > more results than we expected. This is because when PhrasePositions
> falls off
> > > the end of the iterator, it returns a sentinel value:
> > >
> > >     if (!tp.next()) {
> > >       tp.close();                                 // close stream
> > >       doc = Integer.MAX_VALUE;                    // sentinel value
> > >       return;
> > >     }
> > >
> > > However, I can't see anything else that checks for that sentinel:
> > >
> > >  % grep MAX_ *.java
> > > DateFilter.java:  String end = DateField.MAX_DATE_STRING();
> > > PhrasePositions.java:      doc =
> Integer.MAX_VALUE;                       // sentinel value
> > > TermScorer.java:      doc = Integer.MAX_VALUE;                    //
> set to sentinel value
> > > TermScorer.java:          doc = Integer.MAX_VALUE;                //
> set to sentinel value
> > >
> > > so a very big document ID is finding its way into the result set. Is
> > > this the desired behaviour?
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: *[email protected]
> <[email protected]>*
> > For additional commands, e-mail: [email protected]
> >
> >
>
> --
> Uwe Schindler
> Achterdiek 19, D-28357 Bremenhttps://www.thetaphi.de
> eMail: [email protected]
>
>