[jira] [Created] (PLUTO-672) TCK: Contesting tests that expect JspException to be thrown when the copyCurrentRenderParameters attribute contains a non-boolean value

Neil Griffin created PLUTO-672:
----------------------------------

             Summary: TCK: Contesting tests that expect JspException to be thrown when the copyCurrentRenderParameters attribute contains a non-boolean value
                 Key: PLUTO-672
                 URL: https://issues.apache.org/jira/browse/PLUTO-672
             Project: Pluto
          Issue Type: Bug
          Components: tck
    Affects Versions: 3.0.0
            Reporter: Neil Griffin
            Assignee: Neil Griffin
             Fix For: 3.0.1


The following tests have a {{try ... catch}}} block that assumes {{JspException}} will be thrown when invalid values are specified in portlet related tags.

For example:
{code:xml}
<portlet:renderURL copyCurrentRenderParameters="invalid"/>
{code}

-
 [V2PortletTagLibraryTests2_SPEC2_26_IncludeJSPRender_actionURL22|https://github.com/apache/portals-pluto/blob/master/portlet-tck_3.0/V2PortletTagLibraryTests2/src/main/webapp/WEB-INF/jsp/PortletTagLibraryTests2_SPEC2_26_IncludeJSPRender.jsp#L678]
-
 [V2PortletTagLibraryTests2_SPEC2_26_IncludeJSPRender_renderURL22|https://github.com/apache/portals-pluto/blob/master/portlet-tck_3.0/V2PortletTagLibraryTests2/src/main/webapp/WEB-INF/jsp/PortletTagLibraryTests2_SPEC2_26_IncludeJSPRender.jsp#L1131]
-
 [V2PortletTagLibraryTests3_SPEC2_26_IncludeJSPResource_actionURL22|https://github.com/apache/portals-pluto/blob/master/portlet-tck_3.0/V2PortletTagLibraryTests3/src/main/webapp/WEB-INF/jsp/PortletTagLibraryTests3_SPEC2_26_IncludeJSPResource.jsp#L708]
-
 [V2PortletTagLibraryTests3_SPEC2_26_IncludeJSPResource_renderURL22|https://github.com/apache/portals-pluto/blob/master/portlet-tck_3.0/V2PortletTagLibraryTests3/src/main/webapp/WEB-INF/jsp/PortletTagLibraryTests3_SPEC2_26_IncludeJSPResource.jsp#L1161]

[Pluto's implementation of portlet:renderURL|https://github.com/apache/portals-pluto/blob/master/pluto-taglib/src/main/java/org/apache/pluto/tags/PortletURLTag286.java#L118] defines the copyCurrentRenderParameters attribute as a String, whereas [Liferay defines it as a boolean|https://github.com/liferay/liferay-portal/blob/master/util-taglib/src/com/liferay/taglib/portlet/ActionURLTag.java#L240]. In the case of Liferay, an invalid value like {{"invalid"}} is simply coerced to a boolean.

Since there is no requirement in the Portlet 3.0 Spec to throw {{JspException}}, recommend that the tests be changed to test for either {{JspException}} or a value of {{false}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)