[jira] [Closed] (PLUTO-696) TCK: Contesting V2 tests that expect PortletURL.setParameter methods to remove the value when null is passed

     [ https://issues.apache.org/jira/browse/PLUTO-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Neil Griffin closed PLUTO-696.
------------------------------
    Resolution: Fixed

Fixed in commit [8d5aeab347e25f05fae73f0acb7df9ea70949437|https://github.com/apache/portals-pluto/commit/8d5aeab347e25f05fae73f0acb7df9ea70949437].

The changes include:
- Moved V3 related tests from V2URLTests to V3URLTests
- Added V2 related tests to V2URLTests
- Fixed Apache Pluto so that it correctly implements the V2 and V3 functionality

> TCK: Contesting V2 tests that expect PortletURL.setParameter methods to remove the value when null is passed
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: PLUTO-696
>                 URL: https://issues.apache.org/jira/browse/PLUTO-696
>             Project: Pluto
>          Issue Type: Bug
>          Components: tck
>    Affects Versions: 3.0.0
>            Reporter: Neil Griffin
>            Assignee: Neil Griffin
>            Priority: Major
>             Fix For: 3.0.1
>
>
> Apache Pluto fails the legacy Portlet 2.0 TCK SetParameterWithValuesIllegalArgumentExceptionTestPortlet because {{PortletURL.setParameter(String name, String value)}} and {{PortletURL.setParameter(String name, String... values)}} do not throw {{IllegalArgumentException}} when {{null}} is passed for the value.
> The following V 2.0 tests in the new Portlet 3.0 TCK are testing the Portlet 3.0 behavior, which is to *remove* the parameter from the URL when {{null}} is passed:
> - V2URLTests_BaseURL_ApiRenderActurl_setParameterB7
> - V2URLTests_BaseURL_ApiRenderRenurl_setParameterB7
> - V2URLTests_BaseURL_ApiRenderResurl_setParameterB7
> In order to fix this problem, these tests should test for {{IllegalArgumentException}}, and testing for removal should be done in V3URLTests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)