Re: [PR] Adjusting XSLFDrawing's slide shape tree scan in constructor to prevent shape ID warnings. [poi]

pjfanning (via GitHub) <[email protected]> Tue, 28 Jul 2026 14:13:18 -0000

Newsgroups	gmane.comp.jakarta.poi.devel
Message-ID	<PR_kwDOAAMmIM7z7yMa-4d70e974-9572-4fc7-b2d0-5cb3c5c72e5a@gitbox.apache.org>

pjfanning commented on PR #1187:
URL: https://github.com/apache/poi/pull/1187#issuecomment-5105270347

   Merged. I still don't like using mockito here but I don't have time to come up with a different approach. In future, I'm likely to just block PRs with mockito testing. This is a lib where everything should be testable already and we can always expose state via package private getters to expose more state that can be verified.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]