Re: [I] Picture Resize fails due to error in getDimFromCell () [poi]

adityaanikam commented on issue #1201:
URL: https://github.com/apache/poi/issues/1201#issuecomment-5252892071

   Confirmed the code matches your quote exactly. Worked through the math on the hssfUnits <= 0 branch myself: with trailSpace = dim - endD as it stands, targetSize comes out to endD - startD in the single cell case, not quite the -startD - endD your comment states, looks like a small slip in your own derivation there. But your fix holds up regardless: trailSpace = endD gives dim - startD - endD, which is the only version that lines up semantically with the hssfUnits > 0 branch right above it (both represent the same trailing space, just in different units). I'd like to put up that fix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]