Re: [PR] Keep cell number formats when plotting chart data f rom a sheet range [poi]

pjfanning commented on code in PR #1189:
URL: https://github.com/apache/poi/pull/1189#discussion_r3769229877


##########
poi-ooxml/src/main/java/org/apache/poi/xddf/usermodel/chart/XDDFDataSource.java:
##########
@@ -56,6 +56,22 @@ default String getFormula() {
 
     String getFormatCode();
 
+    /**
+     * Optional number format for a single data point in the numerical cache.
+     * <p>
+     * Return {@code null} when this point has no point-specific format and should
+     * inherit the series format from {@link #getFormatCode()}. Implementations that
+     * never use per-point formats can keep the default.
+     * </p>
+     *
+     * @param index zero-based point index
+     * @return the point's format code, or {@code null} to fall back to {@link #getFormatCode()}

Review Comment:
   ```suggestion
        * @return the data point's format code, or {@code null} if the underlying class does not support this method or if there is no format code set for this data point - NumericalCellRangeDataSource is one class that implements this method.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]