Re: [PR] IRR: fall back to bracketed Newton-Raphson when t he iteration diverges (bug 64137 follow-up) [poi]

pjfanning commented on code in PR #1216:
URL: https://github.com/apache/poi/pull/1216#discussion_r3788970069


##########
poi/src/main/java/org/apache/poi/ss/formula/functions/Irr.java:
##########
@@ -130,7 +168,149 @@ public static double irr(double[] values, double guess) {
             x0 = x1;
         }
         // maximum number of iterations is exceeded
-        LOGGER.atWarn().log("Returning NaN because IRR has reached max number of iterations allowed: {}", MAX_ITERATION_COUNT);

Review Comment:
   why are you removing the logging? not just this, the ones above too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]