Re: [PR] IRR: fall back to bracketed Newton-Raphson when t he iteration diverges (bug 64137 follow-up) [poi]

falhenaki commented on PR #1216:
URL: https://github.com/apache/poi/pull/1216#issuecomment-5305263287

   Thanks PJ, It seems that the only major issue/finding that the AI came up with was retracted at the end of the finding. 
   As to the other minor findings:
   1. I added a comment as this was intentional
   2. flo is used, it decides orientation. 
   3. The newtonIrr javadoc says "Kept unchanged as the fast path so existing results stay identical,"  so this is already documented
   4. The guard is there..  it's the result > -1 check in irr(), which is exactly what routes those cases to the fallback. The javadoc on irr() already explains this but i added a comment. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]