Re: DO NOT REPLY [Bug 36026] - Quota Listener

Hi Antoine,

I don't work on Slide anymore but I will answer because I have worked a 
long time on the quota listener. :-)
I don't remember exactly my code but I will try to give you correct 
answers...

1. About the package :
The quota listener is at the same place as the other listeners 
(org.apache.slide.event) but as you say it uses code in 
src/webdav/server - that is why I have modified the build.xml file to 
compile the needed sample of code before compiling the quota listener. 
It is not the best way to do, we should do something cleaner and perhaps 
move the quota listener into another package... I wonder if it is clean 
to separate the quota listener from the other listeners... What do you 
think ?

2. About QuotaConstants.getParentUri  :
Ok ;-)

3. About NAMESPACE_ESUP :
No problem... This information can be retrieved from the Domain.xml 
easily. (And we have to remove the term "ESUP" too...)

4. "Can you explain where the value of the quota limit is defined. I did 
not understand that ?"
quota limit = DAV:quota-used-byte + DAV:quota-available-bytes
As far as I remember, in the RFC dealing with DAV quota, there are only 
two DAV metadata defined. But we can get the full available space adding 
these two metadata.


Comments :
+ To initialize and modify quota, we have a custom DAV client requesting 
a Web service attached to our Slide server. It was the only solution (I 
think) given that quota MD are protected. It would we a good think to 
update the Slide client with such methods.
+ The quota listener is not 100% compliant with the DAV quota RFC 
because of our "virtual root" system. This virtual root is very very 
usefull but I wonder if it must be integrated in Slide's code...
+ At the university of Rennes 1 Slides runs in a production environment 
with quota support. It seems to work well :-)
 
> Hi,
>
> sorry in the long time to get back to you :(
>
> Following remarks.
> I was wondering first where your code fits.
> It seems to need to be under src/webdav/server, although you gave it the package
> name org.apache.slide.event, which is under src/share. src/share builds before
> src/webdav/server, but your code uses classes from src/webdav/server. I suggest
> a package name of org.apache.slide.webdav.event.quota for your code.
>
> In my sandbox, I removed this method 	/**
> 	QuotaConstants.getParentUri (String uri) {
> because it was using StringUtils from commons-lang which was not used yet.
>
>
> Can you also replace the constant NAMESPACE_ESUP by a value that would be picked
> up from domain.xml ?
>
> Can you explain where the value of the quota limit is defined. I did not
> understand that ?
>
> Regards,
>
> Antoine
>
>