Re: looking at roller upgrade again

>@Greg Huber is the current approach ok?
>https://github.com/apache/struts/pull/678

This works but not really related to this formatting issue.

As there is nothing wrong with Struts, it never formatted it correctly in the first place, which can be seen from the test clickById :

clickById("entry_%{#mainAction}!publish")
  

This patch fixes the format by calculating the action first:

https://github.com/apache/struts/commit/d7cf72c92eb84437eb9794b56c2525b389cf7900

Maybe there is another approach that other tags use?   I will have another look.

On 19/04/2023 07:51, Lukasz Lenart wrote:
> I'm sorry Yasser if you took this personally - escape logic has
> changed and on first thought that was the cause. After investigating
> the thing deeper I found it isn't just this but also missing support
> for evaluation of ID which bases on action or method.
>
> Previously ID was evaluated on set (in the setter) to overcome some
> problems, yet it was too early and I have changed this logic sometime
> ago, yet still this affected only tags with ID defined.
>
> @Greg Huber is the current approach ok?
> https://github.com/apache/struts/pull/678
>
>
> Cheers
> --
> Łukasz
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>