Re: check response on app

Lukasz Lenart <[email protected]> Mon, 29 Jun 2026 21:27:21 +0200
Newsgroups gmane.comp.jakarta.struts.devel
Message-ID <CAMopvkMiBmX-wN=iwT_NcVy1JcNzCC9oDvgay0dP9HHN_gEWpw@mail.gmail.com>
sob., 27 cze 2026 o 10:58 Greg Huber <[email protected]> napisa=C5=82(a):
>
> If we can fix this then good.
>
> If I understand it correctly, escapehtml=3Dfalse, then apply either
> escapeJavaScript or escapeXml or escapeCsv ?

Yes, exactly that's what WW-5639 proposes. The four flags become
mutually exclusive and exactly one escaper is applied, by first-match
precedence:
escapeHtml -> escapeJavaScript -> escapeXml -> escapeCsv

Since escapeHtml defaults to true, the default (HTML-escape only)
doesn't change. The only outputs that change are the broken combos
that were already producing corrupt double-/cross-escaped results,
like the <b><\/b> you hit.

> I did try this, (escapeHtml -> escapeJavaScript) but was left with the
> unterminated html
>
> the quick fix I used for the layout problem, was to drop
> escapeJavaScript add an additional escape on any field that returned
> into the response (with escapehtml=3Dfalse)
>
>   s =3D Strings.CS.replace(s, "\"", "&quot;");
>   s =3D Strings.CS.replace(s, "<", "&lt;");
>   s =3D Strings.CS.replace(s, ">", "&gt;");
>
> Probably not the correct way comparing with commons.text
> escapeEcmaScript (the experts), but escaping js correctly and make it
> play nicely seems a minefield.

I want to flag two things, because I don't think this ticket gives you
what you're actually after:

escapeJavaScript is not XSS protection. It escapes only ' " \ / and
control chars, it does NOT touch <, > or &. So escapeHtml=3Dfalse +
escapeJavaScript=3Dtrue still emits a live <script> into the page. The
real exposure is escapeHtml=3Dfalse itself, which outputs raw HTML and
is unsafe unless the value is fully trusted. So the "warning" we
discussed shouldn't say "set escapeJavaScript=3Dtrue", that's a false
sense of safety.
"Allow <b>/<strong>, block <script>" can't be done with these flags.
Escaping HTML and allowing HTML markup are opposite output contexts -
that's why escapeHtml=3Dfalse + escapeJavaScript=3Dtrue mangles the
closing tags. What you want is an allowlist HTML sanitizer (e.g. OWASP
Java HTML Sanitizer), applied to the value before output, with
escapeHtml=3Dfalse on a value you've already sanitized. That keeps
<b>/<strong>/<em> and strips/encodes <script>. The property tag's
escape flags aren't the right tool for it.

Your manual workaround (escaping " < >) is safe, but note it's
effectively just escapeHtml=3Dtrue again, so <b> will render literally
rather than bold. Fine if you don't actually need the formatting on
those fields.

So WW-5639 makes the tag's behavior predictable and stops the
corruption, plus updates the docs/JavaDoc and adds a devMode warning
when more than one flag is set. It just won't, by itself, give you
"formatting yes, scripts no"  that needs the sanitizer.

You can implement a function and then call it via %{} expression like this:
<s:property value=3D"%{sanitize(actionError)}"/>


Cheers
=C5=81ukasz