A suggestion about jakarta-taglibs-standard-1.1.2-src
"knlyknly" <[email protected]>
| Newsgroups | gmane.comp.jakarta.taglibs.devel |
|---|---|
| Message-ID | <000801c88436$ba5fcc80$6401a8c0@knlyknly> |
I've downloaded jakarta-taglibs-standard-1.1.2-src.tar.gz
2008.3.12
in the file
/jakarta-taglibs-standard-1.1.2-src/standard/src/org/apache/taglibs/standard/tag/common/sql/QueryTagSupport.java
Line 276-278:
throw new JspException(Resources.getMessage("DATASOURCE_INVALID",ex.toString()));
and I think
throw new JspException(Resources.getMessage("DATASOURCE_INVALID",ex.toString()),ex);
would be better for users who want to get the cause exception instead of only a message.
And how about
if(ex instanceof SQLException)
throw (SQLException)ex;
else
throw new JspException(Resources.getMessage("DATASOURCE_INVALID",ex.toString()),ex);