Re: Split package caused by DisableStrictChecks

Hello Thiago and Ben,

Thank you for picking this up and sharing your views.

> Oh, I should have thought of this before: since @DisableStrictChecks
> is in org.apache.tapestry5.annotations, but in tapestry-core, we can
> just move it to the same package in tapestry5-annotations. No
> backward-incompatible changes. Win-win! Other tapestry-core
> annotations like @InjectComponents are already there, so there's no
> need to create a org.apache.tapestry5.*core*.annotations package.

I think you got that confused, Thiago. At this time, @DisableStrictChecks is in org.apache.tapestry5.annotations within tapestry5-annotations (not tapestry-core). All other annotation of package org.apache.tapestry5.annotations are in tapestry-core.

From the discussion so far I understand the consensus is to have all annotations in tapestry5-annotations. That is, the 54 files (53 annotations + package-info.java) currently living in tapestry-core would stay in the org.apache.tapestry5.annotations package but would move to tapestry5-annotations. This should be smooth for users, as tapestry-core has a transitive dependency on tapestry5-annotations (through tapestry-ioc) already. For clarity, a direct dependency to tapestry5-annotations should be added to tapestry-core.

I created https://issues.apache.org/jira/browse/TAP5-2724 to take care of this.

Thanks,

Volker