Re: Thoughts for 5.8.2

Hello!


> It seems to be fixed and has a very nice unit test. I've closed it. By
> the way, the other day I was looking at tickets and there were a
> number of them with fixes but apparently people forgot to update the
> ticket accordingly.
>

That's a point on my (neverending) todo-list: going through the most recent
tickets and check if they're still relevant and update accordingly, so we
have a clearer picture of the actually open issues.


We don't need to wait a few months to cut a new release. This has
> happened due to lack of stuff to include in a release. Any committer
> of the Tapestry team can do a release. It requires some effort,
> specially the first time (setting up GnuPG, etc), and the process is
> documented in the Tapestry site.
>

I'm thinking about switching to signed commits, so I need to get used to
GnuPG anyway.
Going to check out the release guide if I find some time.



> Another possibility is to check the original source: the first commit,
> 11 years ago (!!!) says the code is borrowed from Quartz. Our copy
> hasn't been updated ever since, while I'd guess Quartz's one has been
> changed a number of times since then:
>
> https://github.com/quartz-scheduler/quartz/blob/master/quartz-core/src/main/java/org/quartz/CronExpression.java
> .
>

I concur with Thiago that it shouldn't postpone the release.
Hopefully, the code just have to be updated with any changes since it was
introduced.
The test case will help, thanks!


I got one addition to 5.8.2 that's not on the list so far, a ticket I've
just created: TAP5-2728 EventContext enhancements.

It adds two new methods to EventContext:

   - boolean isEmpty()
   - <T> Optional<T> tryGet(Class<T> desiredType, int index)


The change includes unit tests, but I switched the existing ones to
tapestry-spock, so I've added the project as a test dependency.

This time, I'll create a new branch, so you can check out the code before
it hopefully ends up in master.


Cheers
Ben