Re: Adding @InjectComponent(optional = true) to complement @DisableStrictChecks

On Wed, Jun 1, 2022 at 3:36 AM Ben Weidig <[email protected]> wrote:

> Hi Thiago,

Hello!

> I always forget about making a new branch, I'll try to do that in the
> future for non-trivial changes!

Yeah, it usually makes everything easier to manage. :)

> TAP5-2727 is pushed in masters now.

Thanks! But have you pushed to the repository in GitHub directly,
without going through gitbox.apache.org? Or maybe the ASF mirroring
isn't working? I'm trying to commit something and I'm getting this:

thiago@ars-desktop ~/w/tapestry-5 (master)> git push
Username for 'https://gitbox.apache.org': thiagohp
Password for 'https://[email protected]':
Enumerating objects: 23, done.
Counting objects: 100% (23/23), done.
Delta compression using up to 8 threads
Compressing objects: 100% (19/19), done.
Writing objects: 100% (23/23), 6.29 KiB | 6.29 MiB/s, done.
Total 23 (delta 4), reused 0 (delta 0), pack-reused 0
remote: To github:apache/tapestry-5.git
remote:  ! [rejected]
227b29507c3ebd9cbcacae0e77df17fe4e41cbcc -> master (fetch first)
remote: error: failed to push some refs to 'git@github:apache/tapestry-5.git'
remote: hint: Updates were rejected because the remote contains work that you do
remote: hint: not have locally. This is usually caused by another
repository pushing
remote: hint: to the same ref. You may want to first integrate the
remote changes
remote: hint: (e.g., 'git pull ...') before pushing again.
remote: hint: See the 'Note about fast-forwards' in 'git push --help'
for details.
remote: Syncing refs/heads/master...
remote: Could not sync with GitHub:
remote: Error running update hook: /x1/gitbox/hooks/update.d/01-sync-repo.py
remote: error: hook declined to update refs/heads/master
To https://gitbox.apache.org/repos/asf/tapestry-5.git
 ! [remote rejected]     master -> master (hook declined)
error: failed to push some refs to
'https://gitbox.apache.org/repos/asf/tapestry-5.git'

I see the GitHub repository, which is supposed to be a mirror, 1
commit ahead of the gitbox repository. And the canonical repository is
the gitbox one.

> Yeah, it's great to see so much activity and new features and improvements!

It sure is!

Cheers!

-- 
Thiago