Re: Ok to modify bundled Bootstrap source?

On Fri, Jun 17, 2022 at 2:33 PM Volker Lamp <[email protected]> wrote:

> Hi guys

Hello!

> I need your help with a legal/licenese question, I guess.
>
> Trying to tackle the Bootstrap Popover issue
> (https://issues.apache.org/jira/browse/TAP5-2686), I got as far as
> understanding the cause of the problem.
>
> In a nutshell, there is bug in Bootstrap's popover.js that prevents
> popovers from working with Bootstrap 4.3.1 (the release currently
> bundled with Tapestry). The bug was fixed in Bootstrap 4.6.0. See my
> comment in Jira for details.
>
> My question is, can we just modify the popover.js in Bootstrap 4.3.1 to
> fix the bug? It's a trivial change (remove 3 characters), but it's still
> a change. Our source code is open to the public, so I guess we can?

Yes, we can. It's released under the MIT license, which is very
permissive. I love the license info given by GitHub:
https://github.com/twbs/bootstrap/blob/main/LICENSE

> As an alternative, we should upgrade the bundled Bootstrap to 4.+ to
> make popovers work and resolve the issue.

I prefer this idea. Win-win: we get the fix without having to maintain
an altered Bootstrap version.

Anyway, I believe we should be doing a better job of upgrading
Tapestry's dependencies. Since it would be a minor version change, I
suppose it would be a backward compatible change and no Tapestry code
would need to be changed. By the way, at my day job we enabled
Dependabot (https://github.com/dependabot) for auromated checking for
dependency upgrades, but it only works with Maven, not Gradle, so I
was thinking doing that indirectly: creating a GitHub project with
dependencies on all Tapestry subrojects available and have Dependabot
enabled.

> Thank you and have a nice weekend everyone.

Thanks! Same for you!

>
> Volker
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>


-- 
Thiago