Re: Upgrading to jQuery 3.5.1

On Wed, Jul 20, 2022 at 5:39 PM Thiago H. de Paula Figueiredo
<[email protected]> wrote:
> Yes. And/or maybe have a new configuration symbol for jQuery file
> location with the default being the current location.

Somehow I overlooked Peter's great point above, so I'd say Tapestry
should definitely have a symbol so the user can choose any version of
jQuery they want or need. This would help implement his idea of
automatically using jQuery 3.6.1 when the Bootstrap 4 trait is used.
Or switch the default jQuery to be 3.6.1 and have a jquery-1
infrastructure or trait that automatically makes Tapestry use jQuery
1.12.x, plus documenting this in release notes and other pages
mentioning JavaScript and jQuery.

Regarding jquery-migrate, it's easy to add something to the core
JavaScript stack and have it automatically included everywhere JS is
used, so I think we should document that and we don't have to have
configurations for that.

>
> > I'm the first to admin I'm neither a jQuery nor a JavaScript expert. Yet from the jQuery website [1] I understand that jQuery 3.x is backwards compatible all the way back to jQuery 1.9+ (with the jQuery Migrate Plugin activated). The jQuery Migrate GitHub page [2] states a later version, namely jQuery 1.12.x, as a prerequisite.
> >
> > Anyway, Tapestry's dependency is for jQuery 1.12.1, so there should not be any issues for anyone as long as we support enabling the jQuery Migrate Plugin also for production.
>
> Agreed.
>
> > I'm ok with the conscious user decision, but I don't like sticking to jQuery 1.12.1 as the default. The default should not be a 6.5 year old release. Setting the value to 'jquery-migrate' would still be a conscious user decision - a decision to continue with the jQuery 1.12.x compatible code.
> >
> > Likewise, delivering TAP5-2732 ("change the default value to 'jquery' - something Tapestry users were 'warned' that would happen one day years ago) will force those Tapestry users that want to stick with Prototype to make an active change to that configuration setting. Not asking for too much, in my opinion.
>
> Agreed.
>
> >
> > I'll add my preferred solution to the TAP5-2734 branch so it can be tested easily. Also, there is no rush. The whole thing is a consequence of trying to tackle TAP5-2686 which could also be fixed with making a small change in the Bootstrap 4.3.1 sources bundled with Tapestry.
> >
> > [1] https://jquery.com/download/
> > [2] https://github.com/jquery/jquery-migrate/#readme
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [email protected]
> > For additional commands, e-mail: [email protected]
> >
>
>
> --
> Thiago



-- 
Thiago