Re: Makensis

Hi Chris,

Am 04.07.26 um 14:32 schrieb Christopher Schultz:
> All,
> 
> The environmental setup instructions for MacOS say that a custom build 
> of makensis is required in order to successfully build a Tomcat release 
> -- that the version provided through Homebrew is not acceptable. It 
> appears that the custom build only enables the UNICODE flag.
> 
> I think that's no longer true. It's possible that it hasn't been true 
> since makensis 3.07 [1] (current is 3.12, instructions are for a custom 
> build of 3.10).
> 
> $ brew install makensis
> 
> $ makensis -HDRINFO
> 
> [lots of stuff]
> [...],NSIS_SUPPORT_VERSION_INFO,NSIS_UNICODE,NSIS_UNICODE_MAKENSIS,[...]
> 
> I re-ran my verification build for Tomcat 10.1.57 with makensis directly 
> from Homebrew and the verification was successful.
> 
> So I think we can remove the note about the custom build of makensis for 
> MacOS.
> 
> There is also no mention of makensis being available on Linux, and the 
> recommendation is to use Wine which is yet another dependency.

BUILDING.txt has a point 5 "Using a special "makensis" build on 
non-Windows (optional)"

The documented scons command had the specfis (in addition to UNICODE) to set

NSIS_CONFIG_CONST_DATA_PATH=no

and

VERSION=${nsis.version}

I think variations in both of hem can lead to changes in the created 
installer. See BUILDING.txt point 5 for details. It should be true for 
MacOS as well.

Since I allowed our ant recipe for creating the installer to be used 
outside of Windows and without wine, I did al my verifications of the 
reproducibility with a Linux non-Wine build of makensis.

> The Debian repository includes the nsis package [2] which I think might 
> work, though I haven't tried it. It does list the package as "modified 
> for Debian"). @Igal, do you want to try this instead of messing-around 
> with Wine?

Best regards,

Rainer