Re: (tomcat) branch main updated: Fixes from code review

On 10/07/2026 13:17, [email protected] wrote:
> This is an automated email from the ASF dual-hosted git repository.
> 
> rmaucher pushed a commit to branch main
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
> 
> 
> The following commit(s) were added to refs/heads/main by this push:
>       new 8120a12a0d Fixes from code review
> 8120a12a0d is described below
> 
> commit 8120a12a0dbbaafc104fa0d61a319d480b7ff92c
> Author: remm <[email protected]>
> AuthorDate: Fri Jul 10 14:17:44 2026 +0200
> 
>      Fixes from code review
>      
>      Take advantage of rollback to improve save reliability.
>      Clear out transient memory changes only if save is successful,

Line 1253: There is no rollback if the commit fails

Line 1255-67: Clearing out of transient changes can still fail. Better 
to wrapp all the changes in a single transaction that either suceeds or 
fails.

Lines 1288-1717: Will any of these excetions be thrown no everything is 
in a transaction? Assuming the code is correct, I suspect not. This code 
could be a lot cleaner.

Line 1731: Some of these fields were optional (and are still marked as 
such in the documentation). That migth be a breaking change for some odd 
configurations. No objections to the change if a) the breaking change is 
documented in the migration guide and b) the docs are updated

Mark