Re: [PR] Wrap RewriteRule syntax reference [tomcat]

markt-asf commented on code in PR #1044:
URL: https://github.com/apache/tomcat/pull/1044#discussion_r3794864348


##########
webapps/docs/rewrite.xml:
##########
@@ -527,33 +527,30 @@ RewriteRule ^/(.*)$ ${uc:$1}
       <p>Some hints on the syntax of regular
       expressions:</p>
 
-<!-- TODO: Why is the following pre-formatted non-wrappable text? -->
-<pre>
-<strong>Text:</strong>
-  <strong><code>.</code></strong>           Any single character
-  <strong><code>[</code></strong>chars<strong><code>]</code></strong>     Character class: Any character of the class 'chars'
-  <strong><code>[^</code></strong>chars<strong><code>]</code></strong>    Character class: Not a character of the class 'chars'
-  text1<strong><code>|</code></strong>text2 Alternative: text1 or text2
+<source wrapped="true"><strong>Text:</strong>
+  <strong>.</strong>           Any single character
+  <strong>[</strong>chars<strong>]</strong>     Character class: Any character of the class 'chars'
+  <strong>[^</strong>chars<strong>]</strong>    Character class: Not a character of the class 'chars'
+  text1<strong>|</strong>text2 Alternative: text1 or text2

Review Comment:
   This is the wrong approach. The main issue is that the whole block is not source code, only the first column is. What is required here is a table where the first column uses <code>...</code> and the second column uses standard text. The formatting for different screen widths should then sort itself out.



##########
webapps/docs/rewrite.xml:
##########
@@ -527,33 +527,30 @@ RewriteRule ^/(.*)$ ${uc:$1}
       <p>Some hints on the syntax of regular
       expressions:</p>
 
-<!-- TODO: Why is the following pre-formatted non-wrappable text? -->
-<pre>

Review Comment:
   Removing this is good. This is what the TODO was for,



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]