Re: [VOTE] RC Fulcrum Cache 1.1.1 based on staged repository

Hi Georg,


I cleaned up the easiest of the PMD flagged reports.  Go ahead whenever 
you are ready.


Thanks,

Jeff


On 5/20/21 8:02 AM, Georg Kallidis wrote:
> yes, thanks, go ahead!
>
> I already dropped the artifact from the staging repositories and reverted
> the pom..
>
> I'll wait until I see your updates and prepare then again .. (not before
> tomorrow ;-)
>
> - Georg
>
>
>
> Von:    Jeffery Painter <[email protected]>
> An:     [email protected]
> Datum:  20.05.2021 13:31
> Betreff:        Re: [VOTE] RC Fulcrum Cache 1.1.1 based on staged
> repository
>
>
>
> If you are going to do that, I saw a number of (minor) issues raised in
> the PMD report that I could maybe help clean up prior to the release.
>
>
> -
>
> Jeffery
>
>
> On 5/20/21 3:43 AM, Georg Kallidis wrote:
>> Hi Jeffery,
>>
>> thanks for the fix! I thought I checked it ..
>>
>> Though it might be the best to avoid hassle later on to prepare another
> RC
>> ..
>>
>> I'll prepare it within the next days. ..
>>
>> Best regards, Georg
>>
>>
>>
>> Von:    Jeffery Painter <[email protected]>
>> An:     [email protected]
>> Datum:  17.05.2021 15:53
>> Betreff:        Re: [VOTE] RC Fulcrum Cache 1.1.1 based on staged
>> repository
>>
>>
>>
>> Hi Georg,
>>
>> mvn clean install is fine, however there are some issues with the
>> javadoc generation when running "mvn site"
>>
>> Not sure if this should hold up release or not.  Let me know what you
>> think.  In the meantime, I will try to correct the javadoc issues:
>>
>>
>> This builds fine:
>> mvn clean compile test install
>>
>>
>> mvn site fails:
>>
>> [INFO] Rendering 1 Doxia document: 1 xdoc
>> [INFO] Generating "Changes" report       ---
>> maven-changes-plugin:2.12.1:changes-report
>> [INFO] Generating "FindBugs" report      ---
>> findbugs-maven-plugin:3.0.5:findbugs
>> [INFO] Generating "Javadoc" report       ---
>> maven-javadoc-plugin:3.2.0:aggregate-no-fork
>> [INFO] No previous run data found, generating javadoc.
>> [INFO]
>> 2 errors
>> 5 warnings
>> [INFO]
>> ------------------------------------------------------------------------
>> [INFO] BUILD FAILURE
>> [INFO]
>> ------------------------------------------------------------------------
>> [INFO] Total time:  01:54 min
>> [INFO] Finished at: 2021-05-17T09:47:52-04:00
>> [INFO]
>> ------------------------------------------------------------------------
>> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on
>> project fulcrum-cache: Error generating
>> maven-javadoc-plugin:3.2.0:aggregate-no-fork report:
>> [ERROR] Exit code: 1 -
>>
> /home/painter/apache/stage/fulcrum-cache-1.1.1/src/java/org/apache/fulcrum/cache/impl/DefaultGlobalCacheService.java:120:
>> error: unexpected text
>> [ERROR]      * @exception ObjectExpiredException,
>> [ERROR]        ^
>> [ERROR]
>>
> /home/painter/apache/stage/fulcrum-cache-1.1.1/src/java/org/apache/fulcrum/cache/GlobalCacheService.java:43:
>> error: unexpected text
>> [ERROR]      * @exception ObjectExpiredException,
>> [ERROR]        ^
>> [ERROR]
>>
> /home/painter/apache/stage/fulcrum-cache-1.1.1/src/java/org/apache/fulcrum/cache/GlobalCacheService.java:46:
>> warning: no @param for <T>
>> [ERROR]     <T> CachedObject<T> getObject(String id) throws
>> ObjectExpiredException;
>> [ERROR]                         ^
>> [ERROR]
>>
> /home/painter/apache/stage/fulcrum-cache-1.1.1/src/java/org/apache/fulcrum/cache/GlobalCacheService.java:46:
>> warning: no @throws for org.apache.fulcrum.cache.ObjectExpiredException
>> [ERROR]     <T> CachedObject<T> getObject(String id) throws
>> ObjectExpiredException;
>> [ERROR]                         ^
>> [ERROR]
>>
> /home/painter/apache/stage/fulcrum-cache-1.1.1/src/java/org/apache/fulcrum/cache/GlobalCacheService.java:56:
>> warning: no @param for <T>
>> [ERROR]     <T> void addObject(String id, CachedObject<T> o);
>> [ERROR]              ^
>> [ERROR]
>>
> /home/painter/apache/stage/fulcrum-cache-1.1.1/src/java/org/apache/fulcrum/cache/GlobalCacheService.java:88:
>> warning: no @throws for java.io.IOException
>> [ERROR]     int getCacheSize() throws IOException;
>> [ERROR]         ^
>> [ERROR]
>>
> /home/painter/apache/stage/fulcrum-cache-1.1.1/src/java/org/apache/fulcrum/cache/RefreshableCachedObject.java:117:
>> warning: no @return
>> [ERROR]     public synchronized boolean isUntouched()
>> [ERROR]                                 ^
>> [ERROR]
>> [ERROR] Command line was: /usr/java/jdk1.8.0_281/jre/../bin/javadoc
>> @options @packages
>> [ERROR]
>> [ERROR] Refer to the generated Javadoc files in
>> '/home/painter/apache/stage/fulcrum-cache-1.1.1/target/site/apidocs'
> dir.
>> [ERROR] -> [Help 1]
>> [ERROR]
>> [ERROR] To see the full stack trace of the errors, re-run Maven with the
>> -e switch.
>> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>> [ERROR]
>> [ERROR] For more information about the errors and possible solutions,
>> please read the following articles:
>> [ERROR] [Help 1]
>> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
>>
>>
>>
>> On 5/7/21 9:56 AM, Georg Kallidis wrote:
>>> Hi Turbine devs,
>>>
>>> hopefully this finds you well again!
>>>
>>> A release candidate for the Turbine Fulcrum Cache Component v1.1.1 has
>>> been prepared.
>>>
>>> It contains:
>>>
>>> -   Update JCS to commons-jcs3-core
>>> -   Update Tests
>>> -   Bugfixes, Code cleanup
>>>
>>>
>>> This release is for JCS mainly, EHcache is updated (to 2.10.9.2, not
> yet
>>> 3.x), but not extensively tested and may require more work to do.
>>>
>>> Tag:
>>>
> https://svn.apache.org/repos/asf/turbine/fulcrum/tags/fulcrum-cache-1.1.1
>>> Artifacts:
>>>
>>>
> https://repository.apache.org/content/repositories/orgapacheturbine-1061/
>>> Keys:
>>> https://dist.apache.org/repos/dist/release/turbine/KEYS
>>>
>>>
>>> [ ] +1 release it
>>> [ ] +0 go ahead I don't care
>>> [ ] -1 no, do not release it because
>>>
>>>
>>> Please verify this release candidate carefully and vote, if you are a
>>> Turbine PMC member or a committer (non binding).
>>>
>>> Thanks for your efforts!
>>>
>>> Best regards,
>>>
>>> Georg
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>