[jira] Commented: (JCS-21) JCS has inconsistent locking of shared data

    [ https://issues.apache.org/jira/browse/JCS-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481974 ] 

Aaron Smuts commented on JCS-21:
--------------------------------

Find bugs is not perfect at locating sync problems.  Far from it.  I'll have to look at the changes.   I've never seen it acurately loate a synchronization problem.

> JCS has inconsistent locking of shared data
> -------------------------------------------
>
>                 Key: JCS-21
>                 URL: https://issues.apache.org/jira/browse/JCS-21
>             Project: JCS
>          Issue Type: Bug
>    Affects Versions: jcs-1.2.7.9.2
>            Reporter: Michael Stevens
>         Assigned To: Aaron Smuts
>         Attachments: locking.diff
>
>
> I've been looking at the trunk JCS code with findbugs (http://findbugs.sf.net/).
> One of the things it does is warn when data is inconsistently synchronized - ie when it is sometimes referenced inside a synchronized block and sometimes not. This is not threadsafe - one thread may read old or inconsistent data.
> I've patched all the places findbugs complains about by adding appropriate synchronized() blocks.
> I suspect this change may require some discussion :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.