Re: [VOTE] RC Torque 5.0 based on staged repository

Hi Georg,

I checked out the source from tag and was able to build and compile with 
no issues on my Linux machine (Ubuntu 20.04 fresh install):

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/java/maven
Java version: 1.8.0_261, vendor: Oracle Corporation, runtime: 
/usr/java/jdk1.8.0_261/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.4.0-42-generic", arch: "amd64", family: "unix"

I then went to torque-test/

I was able to run:

mvn clean test -Phsqldb,managers,beans

This completed with all tests passing.


MySQL Issues:

First test updating my pom.xml to use my local timezone:

-------------------------------------------------------------

I updated the torque-test/pom.xml to use my timezone "America/New_York"

painter@merlin:~/apache/torque-5.0/torque-test$ grep New_York pom.xml
<torque.database.url>jdbc:mysql://localhost:3306/bookstore?serverTimezone=America/New_York&amp;useSSL=false&amp;allowPublicKeyRetrieval=true</torque.database.url>

root@merlin:~# timedatectl
                Local time: Sun 2020-08-23 17:11:19 EDT
            Universal time: Sun 2020-08-23 21:11:19 UTC
                  RTC time: Sun 2020-08-23 21:11:19
                 Time zone: America/New_York (EDT, -0400)
System clock synchronized: yes
               NTP service: active
           RTC in local TZ: no


MySQL Server version: 8.0.21-0ubuntu0.20.04.4 (Ubuntu)
mvn clean test -Pmysql,managers,beans

[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] DefaultValuesFromDatabaseTest.testNewObjectChangedValue:214 
expected: <1970-01-01 11:21:31> but was: <1970-01-01 05:21:31>
[INFO]
[ERROR] Tests run: 287, Failures: 1, Errors: 0, Skipped: 0
[INFO]

-------------------------------------------------------------

Second, I try to reset my local timezone to Europe/Berlin

painter@merlin:~/apache/torque-5.0/torque-test$ grep Berlin pom.xml
<torque.database.url>jdbc:mysql://localhost:3306/bookstore?serverTimezone=Europe/Berlin&amp;useSSL=false&amp;allowPublicKeyRetrieval=true</torque.database.url>


painter@merlin:~/apache/torque-5.0/torque-test$ timedatectl
                Local time: Sun 2020-08-23 23:15:06 CEST
            Universal time: Sun 2020-08-23 21:15:06 UTC
                  RTC time: Sun 2020-08-23 21:15:07
                 Time zone: Europe/Berlin (CEST, +0200)
System clock synchronized: yes
               NTP service: active
           RTC in local TZ: no


mvn clean test -Pmysql,managers,beans

[INFO] Results:
[INFO]
[INFO] Tests run: 287, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] 
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] 
------------------------------------------------------------------------
[INFO] Total time:  02:27 min
[INFO] Finished at: 2020-08-23T23:15:33+02:00
[INFO] 
------------------------------------------------------------------------


So unfortunately, I would still say there is a bug in this test case, 
but it is very close! I do not know how to resolve this or I would :-)

[ ] +1 release it
[ ] +0 go ahead I don't care
[x] -1 no, do not release it because


--

Jeffery Painter










On 8/14/20 8:17 AM, Georg Kallidis wrote:
> Hi Torque community,
>
>
> another release candidate for Torque version 5.0 has been prepared and is
> again open for voting!
>
>
> Artifacts:
>
> https://repository.apache.org/content/repositories/orgapachetorque-1002/org/apache/torque/
>
>
> Tag:
>
> https://svn.apache.org/repos/asf/db/torque/torque4/tags/torque-5.0
>
>
> This release contains the following updates:
>
> - fixes from last vote relplies, updated resources, improved build
> workflow.
>
> - 81 resolved JIRA issues:
> https://issues.apache.org/jira/browse/TORQUE-359?jql=project%20%3D%20TORQUE%20AND%20status%20%3D%20Resolved%20AND%20fixVersion%20%3D%204.1
>
>
>   (note, this is still "fix version 4.1", but should be updated to 5.0)
> - a lot of bugfixes, cleanup and refactoring, e.g.
> time/date/timestamp-string formatting, deprecated DBCP1 adapters, DBCP2 is
>
> the default now...
> - Java 8, tested and build in Java 8 and 14 with JUnit 5 and Log4j2
> - updated almost all plugin, build and database dependencies, major
> updates: velocity 2.0, groovy 3.0.4
> - added Docker testcontainer profiles for mysql and postgresql
> - new refactored ant task Torque4JDBCTransformTask
>
> Keys:
> https://svn.apache.org/repos/asf/db/torque/torque4/trunk/KEYS
> https://dist.apache.org/repos/dist/release/db/torque/KEYS (after release
> to be updated)
>
>
> Please verify this release candidate carefully, give feedback or/and vote
>
>
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because
>
>
> Have fun!
>
>
> Best regards, Georg
>
>
>