[jira] [Commented] (TORQUE-362) SharedPool2DataSourceFactory says property is not supported

    [ https://issues.apache.org/jira/browse/TORQUE-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707194#comment-17707194 ] 

Georg Kallidis commented on TORQUE-362:
---------------------------------------

SharedPool2DataSourceFactory does use [dbcp2|https://commons.apache.org/proper/commons-dbcp/index.html] v.2.9, which uses different pool settings than v1.x (though in [changes 2.9|https://commons.apache.org/proper/commons-dbcp/changes-report.html#a2.9.0] state that some props are deprecated, seem to be not more supported at all) .

You might try to use SharedPoolDataSourceFactory, which still uses [dbcp v1.4|https://javadoc.io/doc/commons-dbcp/commons-dbcp/1.4/index.html], which supports the properties you are trying to use.

Support for the new settings are still not completed. E.g. pool.durationBetweenEvictionRuns, which replaces pool.timeBetweenEvictionRunsMillis expects a Duration. 

> SharedPool2DataSourceFactory says property is not supported
> -----------------------------------------------------------
>
>                 Key: TORQUE-362
>                 URL: https://issues.apache.org/jira/browse/TORQUE-362
>             Project: Torque
>          Issue Type: Bug
>          Components: Runtime
>    Affects Versions: 5.0, 5.1
>            Reporter: Max Philipp Wriedt
>            Priority: Major
>              Labels: SharedPool2DataSourceFactory
>
> When I set properties like:
> {code:java}
> torque.dsfactory.test.pool.maxTotal = 20
> torque.dsfactory.test.pool.maxIdle = 15
> torque.dsfactory.test.pool.maxWaitMillis = 10000
> torque.dsfactory.test.pool.timeBetweenEvictionRunsMillis = 300000
> torque.dsfactory.test.pool.minEvictableIdleTimeMillis = 3600000
> // rest of config for reference
> torque.database.default = test
> torque.dsfactory.hvp.factory = org.apache.torque.dsfactory.SharedPool2DataSourceFactory
> torque.database.hvp.adapter = mysql
> torque.dsfactory.test.connection.driver = org.mariadb.jdbc.Driver
> torque.dsfactory.test.connection.url = jdbc:mariadb://localhost:3306/test
> torque.dsfactory.test.connection.user = user
> torque.dsfactory.test.connection.password = password{code}
> the initialization throws:
>  
> {code:java}
> 12:33:09.565 [main] ERROR org.apache.torque.dsfactory.AbstractDataSourceFactory - Property: maxIdle  value: 15  is not supported by DataSource: org.apache.commons.dbcp2.datasources.SharedPoolDataSource
> 12:33:09.570 [main] ERROR org.apache.torque.dsfactory.AbstractDataSourceFactory - Property: maxWaitMillis  value: 10000  is not supported by DataSource: org.apache.commons.dbcp2.datasources.SharedPoolDataSource
> 12:33:09.570 [main] ERROR org.apache.torque.dsfactory.AbstractDataSourceFactory - Property: timeBetweenEvictionRunsMillis  value: 300000  is not supported by DataSource: org.apache.commons.dbcp2.datasources.SharedPoolDataSource
> 12:33:09.571 [main] ERROR org.apache.torque.dsfactory.AbstractDataSourceFactory - Property: minEvictableIdleTimeMillis  value: 3600000  is not supported by DataSource: org.apache.commons.dbcp2.datasources.SharedPoolDataSource {code}
>  
> The reference says those properties exist: [https://commons.apache.org/proper/commons-dbcp/configuration.html]
>  
> Am I missing something here? As you can see, I use the MariaDB JDBC Driver, but I don't think this has effects to the pool properties?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)