[jira] [Commented] (TORQUE-375) Support for java.time API

    [ https://issues.apache.org/jira/browse/TORQUE-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18094581#comment-18094581 ] 

Georg Kallidis commented on TORQUE-375:
---------------------------------------

Thanks a lot for the patches again!

I got them now compiled and finally also the torque-tests run!

At the beginning the last two patches threw two or three rejected errors. Merges for the last patches 5 and 6 seem due to some version incompatibilies (??) or other duplicate settings not accepted. Comparing the total changes all changes were already applied apparently.

I compiled from root with
{code:java}
mvn clean install
{code}
Setting module torque-tests with profile test and running hsqldb-jenkins did throw an error and did not work.

What is running, is running from folder torque-test
{code:java}
mvn clean install -Phsqldb,beans,managers{code}
That is all changed tests are running and the ne ones (e.g. the LocalDate/Time* tests in torque-runtime)

As you already set the database version to 8.0 this is probably what we will fix soon, but later ..

We will merge this soon, if we get not a critic from a Torque dev soon ..

+1 from my side approving this patch.

> Support for java.time API
> -------------------------
>
>                 Key: TORQUE-375
>                 URL: https://issues.apache.org/jira/browse/TORQUE-375
>             Project: Torque
>          Issue Type: Improvement
>    Affects Versions: 7.1
>            Reporter: Graham Leggett
>            Priority: Major
>         Attachments: torque8-javatime1.patch, torque8-javatime2.patch, torque8-javatime3.patch, torque8-javatime4.patch, torque8-javatime5.patch, torque8-javatime6.patch
>
>
> Switch out java.util.Date, replace with the java.time API.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)