Re: [VOTE] Release Velocity Engine version 2.4.1

On 19/02/2024 21:34, Michael Osipov wrote:

> On 2024/02/19 20:25:45 Claude Brisson wrote:
>> Version numbers are advertized and are supposed to be coherent. We don't
>> care that the tags are public, they are not advertized. I didn't say
>> that you had to reuse the tag. The tag can be named 2.4-RC2. You don't
>> have to rename anything, or did I miss something?
> I cannot follow. What am I supported to do with 2.4-RC2? I cannot supply this to Maven Release Plugin otherwise it will bein the POM and in the repo. This is already on master and shouldn't appear again: https://github.com/apache/velocity-engine/commit/5d9e48ca0f1776300f1cf07199eb79c34dbe9cb7
>
> Git tag and version in POM have to be consistent.

They are supposed to be consistent, that's why the tag you put to call 
the vote should be in the form 2.4-RCx. Otherwise, there would be a hole 
in the versioning each time there is a failed vote. Because the RC tag 
was named 2.4, you cannot reuse it, so let's use another tag, it's not a 
big deal.

I don't understand the point with the maven plugin. The plugin -or its 
use- has to adapt to the chosen versioning, not the opposite.

>   I don't see how this can be achieved.

I'm sure that there's a way of doing it. If not, you can still erase the 
2.4 tag, after all. I mean, releasing the 2.4.1 *without* having 
released the 2.4 is... weird. There must be a way.

>   Moreover, that version needs to land as source release zip on ASF dist area. The zip content cannot be x-RCy.

On that, we agree. The RC life span *is* the vote.

   Claude

>
> I guess I miss here something as well.
>
> Michael
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>