Re: [PR] Draft PR for Jakarta ee10 jdk17 [velocity-tools ]
eduarddrenth (via GitHub) <[email protected]>
| Newsgroups | gmane.comp.jakarta.velocity.devel |
|---|---|
| Message-ID | <PR_kwDOAN72Mc510bRH-74720122-0943-41a9-8927-68e7af1b73e9@gitbox.apache.org> |
eduarddrenth commented on code in PR #19:
URL: https://github.com/apache/velocity-tools/pull/19#discussion_r1683785508
##########
pom.xml:
##########
@@ -45,7 +45,9 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <slf4j.version>1.7.36</slf4j.version>
+ <slf4j.version>2.0.13</slf4j.version>
+ <maven.compiler.source>17</maven.compiler.source>
+ <maven.compiler.target>17</maven.compiler.target>
Review Comment:
I know, but the enforcer plugin looks at maven.compiler.target for bytecode compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]