Re: [PR] Draft PR for Jakarta ee10 jdk17 [velocity-tools ]

michael-o commented on code in PR #19:
URL: https://github.com/apache/velocity-tools/pull/19#discussion_r1683880642


##########
pom.xml:
##########
@@ -158,19 +160,19 @@
         <version>${slf4j.version}</version>
       </dependency>
       <dependency>
-        <groupId>javax.servlet</groupId>
-        <artifactId>javax.servlet-api</artifactId>
-        <version>3.1.0</version>
+        <groupId>jakarta.servlet</groupId>
+        <artifactId>jakarta.servlet-api</artifactId>
+        <version>6.0.0</version>
       </dependency>
       <dependency>
-        <groupId>javax.servlet.jsp</groupId>
-        <artifactId>javax.servlet.jsp-api</artifactId>
-        <version>2.3.3</version>
+        <groupId>jakarta.servlet.jsp</groupId>
+        <artifactId>jakarta.servlet.jsp-api</artifactId>
+        <version>4.0.0</version>

Review Comment:
   Not fixed



##########
velocity-tools-view-jsp/src/main/java/org/apache/velocity/tools/view/jsp/jspimpl/VelocityPageContext.java:
##########
@@ -409,20 +408,6 @@ public JspWriter getOut() {
         return jspWriter;
     }
 
-    @SuppressWarnings("deprecation")
-    @Override
-    public javax.servlet.jsp.el.ExpressionEvaluator getExpressionEvaluator() {
-    	// Really, who cares?
-    	throw new UnsupportedOperationException("This class works only with JSP 2.1");
-    }
-
-    @SuppressWarnings("deprecation")
-    @Override
-    public javax.servlet.jsp.el.VariableResolver getVariableResolver() {
-    	// Really, who cares?
-    	throw new UnsupportedOperationException("This class works only with JSP 2.1");
-    }
-

Review Comment:
   Good, thanks. @arkanovicz I wonder whether we should raise to Servlet 4.0 before that.



##########
velocity-tools-view-jsp/src/main/java/org/apache/velocity/tools/view/jsp/jspimpl/JspWriterImpl.java:
##########
@@ -20,7 +20,7 @@
 import java.io.IOException;
 import java.io.Writer;
 
-import javax.servlet.jsp.JspWriter;
+import jakarta.servlet.jsp.JspWriter;

Review Comment:
   Given the comments at class level, I wonder whether we still need this file...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]