Re: [PR] Draft PR for Jakarta ee10 jdk17 [velocity-tools ]

michael-o commented on code in PR #19:
URL: https://github.com/apache/velocity-tools/pull/19#discussion_r1684190649


##########
pom.xml:
##########
@@ -46,6 +46,7 @@
   <properties>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <slf4j.version>1.7.36</slf4j.version>
+    <javaVersion>17</javaVersion>

Review Comment:
   Servlet API 6.0.0 requires Java 11, not 17



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]