Re: [PR] VELOCITY-942 - VelocityViewServlet extending from j akarta.servlet instead of javax.servlet [velocity-tools]

ct-parker commented on PR #15:
URL: https://github.com/apache/velocity-tools/pull/15#issuecomment-2310635321

   > > > @ct-parker Thanks for the offer. I am waiting for a Core release first.
   > > 
   > > 
   > > @michael-o I greatly appreciate your reconsideration of this issue. I am willing to continue the discussion as needed here or in the JIRA issue, so please just let me know of any support you need on this, and I will jump in. I am eager to resolve this.
   > 
   > Please point me to the exact commit you want me to look at and propose as well. I want to check the approach taken.
   
   It was https://github.com/apache/freemarker/pull/104, which had a single commit: https://github.com/apache/freemarker/pull/104/commits/c88ed780669c53ce3979697bf4173cf53d199e6d
   
   They used a code generator (I think FreeMarker itself, with Kotlin and Gradle) which I'm not that familiar with, so I think the end result of the code generation which ends up in "freemarker-src-2.3.33\build\generated\freemarker-jakarta-servlet\main\java\freemarker\ext\jakarta" is the important part. Essentially, the code generator copies the source code for the package/classes of interest into a package named "freemarker.ext.jakarta" and does a search/replace on javax.servlet to jakarta.servlet prior to compiling. See [this part](https://github.com/apache/freemarker/pull/104/commits/c88ed780669c53ce3979697bf4173cf53d199e6d#diff-c0dfa6bc7a8685217f70a860145fbdf416d449eaff052fa28352c5cec1a98c06) in particular. I'm not suggesting using a code generator, but rather simply duplicating the pa
 ckages into a jakarta package and search/replace for the "javax." imports.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]