Re: [PR] VELOCITY-989 - Review data sources resource loading [velocity-engine]

arkanovicz commented on code in PR #62:
URL: https://github.com/apache/velocity-engine/pull/62#discussion_r3126779216


##########
velocity-engine-core/src/main/java/org/apache/velocity/runtime/resource/loader/DataSourceResourceLoader.java:
##########
@@ -121,13 +120,16 @@
  *  );
  * </code></pre>
  * <p>Prior to Velocity 2.4, this class should not be considered thread-safe.</p>
- * <p>Since Velocity 2.4, the handling of JDBC connections and prepared statements is delegated to the
- * {@link org.apache.velocity.runtime.resource.loader.DatabaseObjectsFactory} instance. The default class for this
- * database objects factory is {@link org.apache.velocity.runtime.resource.loader.DefaultDatabaseObjectsFactory},
- * which obtains a new connection from the data source and prepares statements at each query. You can configure this
- * resource loader to use the {@link org.apache.velocity.runtime.resource.loader.CachingDatabaseObjectsFactory} which
- * will keep a single connection and tries to reuse prepared statements.
- * statements</p>
+ * <p>Since Velocity 2.5, the handling of JDBC connections and prepared statements is delegated to a
+ * {@link org.apache.velocity.runtime.resource.loader.PreparedStatementsFactory} instance (the older
+ * {@link org.apache.velocity.runtime.resource.loader.DatabaseObjectsFactory} remains supported but is
+ * deprecated). The default class is
+ * {@link org.apache.velocity.runtime.resource.loader.DefaultPreparedStatementsFactory}, which obtains a
+ * new connection from the data source and prepares a statement at each query. Connection pooling and

Review Comment:
   Fixed, also clarified config properties for a custom factory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]