[ ant-contrib-Bugs-1911616 ] doc: Incorrect propertycopy def'n in propertyselector e.g.

Bugs item #1911616, was opened at 2008-03-11 00:15
Message generated for change (Comment added) made by m_grove
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=416920&aid=1911616&group_id=36177

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: M Grove (m_grove)
Assigned to: Nobody/Anonymous (nobody)
Summary: doc: Incorrect propertycopy def'n in propertyselector e.g.

Initial Comment:
In http://ant-contrib.sourceforge.net/tasks/tasks/propertyselector.html
the example at the bottom shows: 
[...]
<target name="print.name" >
      <propertycopy name="pack.name" value="package.${pack.id}.name" />
      <echo message="${pack.name}" />
</target>
[...]

This example is incorrect for several reasons:

1) The name attribute of propertycopy has been deprecated. It should be replaced with the property attribute.

2) propertycopy does not have a value attribute; it has a from attribute.

3) pack.name property has already been set, therefore the overrides attribute of propertycopy must be set to "true".

I believe the example should read as follows:
[...]
<target name="print.name" >
      <propertycopy property="pack.name" from="package.${pack.id}.name" overrides="true"/>
      <echo message="${pack.name}" />
</target>
[...]

----------------------------------------------------------------------

>Comment By: M Grove (m_grove)
Date: 2008-03-11 00:59

Message:
Logged In: YES 
user_id=2032889
Originator: YES

Edit: Ignore #3 (overrides)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=416920&aid=1911616&group_id=36177

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/