Re: Questions and possible patch
Jim Ray <[email protected]> 10 Jan 2003 14:11:36 -0700
| Newsgroups | gmane.comp.java.anthill.devel |
|---|---|
| Message-ID | <[email protected]> |
--=-h9TJAw25Z2Qv5J3s+Qr9 Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, 2003-01-10 at 13:52, Maciej Zawadzki wrote: > Jim, > > These sounds like very nice patches. > > I know that once in a while people ask about exactly the functionality > that you've described for the build off of a label feature. Can you > walk me through how you guys will use this feature? This would be just > for my benefit so that I can learn more about the different practices > that people use. Right now I imagine that your development team at some > point says that all the code is complete, so maybe the lead developer > labels the code as "complete." Then, you have an Anthill project set up > to build the "complete" label. Is this correct thus far? If so, then > how do nightly builds and continuous integration builds play into this? So here is a little workflow that we kind of use: Develop Code / Fix Bugs -> Nightly / CI Build -> Developer Labels upon successful build -> Release Build Done Nightly and CI builds are done on the HEAD of the project. The label allows for a successful point to be labeled and development can continue while a release build is happening. > On the disable CVS style label, why don't we just move the code that > makes the label safe for CVS into the CVS adapter? We have the > makeTagFromVersion(String) method in the RA interface but for some > reason (an oversight on our part) we do not use that method to make the > version label safe for CVS, instead we make the label safe in the > ProfileAdapter.label() method, which gets used by all the adapters. So > what I propose on this issue is that we move lines 375 and 376 of > ProfileRepositoryAdapter into the > CVSRepositoryAdapter.makeTagFromVersion() method. I believe that if we > do that, then we will not need the extra property in the PerforceAdapter > screen. Would that work for you? > Works for me. I was trying to understand why the code was in the PerforceRepositoryAdapter anyway. > I think the label prefix is a nice enhancement. I'm trying to think of > how we could make this apply to more than just Perforce, but I think > we'll just have to add this feature to each RA one by one. > ok. > Is it possible for you to enter each one of these as a separate issue in > bugzilla, each with its own zip file? If it's too much work, then don't > worry about it. > No that's ok. I can do that. > Also, can you make sure that you patches are relative to the latest > source. I know that we just made some changes to the Perforce adapter, > specifically how it works with views and labels. > I'm going to do this tonight/tomorrow morning. I just want to do some testing through the weekend to make sure you are not getting any broken code. -- Jim Ray <[email protected]> --=-h9TJAw25Z2Qv5J3s+Qr9 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/1.1.6"> </HEAD> <BODY> On Fri, 2003-01-10 at 13:52, Maciej Zawadzki wrote: <BLOCKQUOTE TYPE=CITE> <PRE><FONT COLOR="#737373" SIZE="3"><I>Jim, These sounds like very nice patches. I know that once in a while people ask about exactly the functionality that you've described for the build off of a label feature. Can you walk me through how you guys will use this feature? This would be just for my benefit so that I can learn more about the different practices that people use. Right now I imagine that your development team at some point says that all the code is complete, so maybe the lead developer labels the code as "complete." Then, you have an Anthill project set up to build the "complete" label. Is this correct thus far? If so, then how do nightly builds and continuous integration builds play into this?</I></FONT></PRE> </BLOCKQUOTE> <FONT SIZE="3"><BR> So here is a little workflow that we kind of use:<BR> <BR> Develop Code / Fix Bugs -> Nightly / CI Build -> Developer Labels upon successful build -> Release Build Done<BR> <BR> Nightly and CI builds are done on the HEAD of the project. The label allows for a successful point to be labeled and development can continue while a release build is happening.<BR> </FONT><BR> <BLOCKQUOTE TYPE=CITE> <PRE><FONT COLOR="#737373" SIZE="3"><I>On the disable CVS style label, why don't we just move the code that makes the label safe for CVS into the CVS adapter? We have the makeTagFromVersion(String) method in the RA interface but for some reason (an oversight on our part) we do not use that method to make the version label safe for CVS, instead we make the label safe in the ProfileAdapter.label() method, which gets used by all the adapters. So what I propose on this issue is that we move lines 375 and 376 of ProfileRepositoryAdapter into the CVSRepositoryAdapter.makeTagFromVersion() method. I believe that if we do that, then we will not need the extra property in the PerforceAdapter screen. Would that work for you? </I></FONT></PRE> </BLOCKQUOTE> <FONT SIZE="3">Works for me. I was trying to understand why the code was in the PerforceRepositoryAdapter anyway. <BR> </FONT><BR> <BLOCKQUOTE TYPE=CITE> <PRE><FONT COLOR="#737373" SIZE="3"><I>I think the label prefix is a nice enhancement. I'm trying to think of how we could make this apply to more than just Perforce, but I think we'll just have to add this feature to each RA one by one. </I></FONT></PRE> </BLOCKQUOTE> <FONT SIZE="3"><BR> ok.<BR> </FONT><BR> <BLOCKQUOTE TYPE=CITE> <PRE><FONT COLOR="#737373" SIZE="3"><I>Is it possible for you to enter each one of these as a separate issue in bugzilla, each with its own zip file? If it's too much work, then don't worry about it. </I></FONT></PRE> </BLOCKQUOTE> <FONT SIZE="3">No that's ok. I can do that. <BR> </FONT><BR> <BLOCKQUOTE TYPE=CITE> <PRE><FONT COLOR="#737373" SIZE="3"><I>Also, can you make sure that you patches are relative to the latest source. I know that we just made some changes to the Perforce adapter, specifically how it works with views and labels. </I></FONT></PRE> </BLOCKQUOTE> <FONT SIZE="3"><BR> I'm going to do this tonight/tomorrow morning. I just want to do some testing through the weekend to make sure you are not getting any broken code. <BR> </FONT><BR> <PRE><TABLE CELLSPACING="0" CELLPADDING="0" WIDTH="100%"> <TR> <TD> -- <BR> Jim Ray <<A HREF="mailto:[email protected]">[email protected]</A>> </TD> </TR> </TABLE> </PRE> </BODY> </HTML> --=-h9TJAw25Z2Qv5J3s+Qr9--