Re: Questions and possible patch

Jim,

I would like patches to be placed within Bugzilla.  That way they are 
easier to track and also it is easier for us to figure out exactly what 
is going into a release.  You can create an issue in Bugzilla for your 
enhancement and then add an attachment (zip file with your changes) to 
the issue.

Can you provide a little more detail on the building off a label patch? 
  I ask because the patches that are the easiest to integrate and 
therefore the one that will be integrated first are the ones that treat 
all source repositories equally.  This does not mean that you can't have 
a Perforce specific patch.  You can totally have a patch like the 
"disable CVS style tagging" that applies only to Perforce.  But, I'm 
worried about the "building off label for Perforce" patch since it has 
the potential to affect the build screen which is used by all projects 
(regardless of repository).

Basically, if your patch is going to be repository specific, then that 
is ok as long as all changes are local to the repository adapter.  If 
your patch is going to include changes beyond the repository adapter 
(such as the build screen), then we need to make sure that all the other 
repository adapters can handle that change as well.

Thanks,

--Maciej

Jim Ray wrote:
> Do you want patches to come to this list now, or directly to one of the 
> guys at Urban Code?
> I have a patch that allows for building off a label with Perforce and 
> also working on one for adding a "label prefix" to Perforce labels.  
> It's set up like the view so  neither are mandatory.
> After looking at the jsp I figured out that there is no way to specify a 
> input type to add radio buttons to a repository profile.  Would this be 
> something useful for the future or am I the only one that would like to 
> have this?
> The reason behind it is; I would like to add a field for "Disable CVS 
> style tagging".  If the answer is yes, don't do the replacement on the 
> version string. No does the current replacement.
> 
> Jim
> 
>