[aspectwerkz-dev] [jira] Deleted: (AW-99) Fixed a lot of static usage warnings

     [ http://jira.codehaus.org/browse/AW-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

[email protected] deleted AW-99:
--------------------------------


> Fixed a lot of static usage warnings
> ------------------------------------
>
>                 Key: AW-99
>                 URL: http://jira.codehaus.org/browse/AW-99
>             Project: AspectWerkz
>          Issue Type: Improvement
>         Environment: Version 0.8.1
>            Reporter: Jeppe Cramon
>            Assignee: Jonas Boner
>            Priority: Trivial
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> Hi
> I get so many warnings when working with the AspectWerkz sourcecode in Eclipse, so I tried to fix them. All of them are due to "wrong" static variable usage.
> In most files it's due to calling factory.createLoad() instead IntructionFactory.createLoad() (or some other static method on that class).
> I've included the fixed sourcefiles, but they're from version 0.8.1, so there's a risk of overwriting code changes since then. I tried to download a Tar ball from ViewCVS so mI could get the latest sourcecode, but quite a few of the files ended with 00775 instead for .java, so I gave up on that (I haven't had problems downloading tar balls from other projects, so I'm not sure what goes wrong). Maybe it's WinZip?
> Also there a piece of code, which also has static warnings that I'm unsure about, therefore no fix to it. The code appears in both ClassPattern, FieldPattern and MehtodPattern.
> I haven't looked to much at the code, so this might not be a problem:
>         return areEqualsOrBothNull(obj.m_pattern, this.m_pattern)
>                 && areEqualsOrBothNull(obj.m_classNamePattern, this.m_classNamePattern)
>                 && areEqualsOrBothNull(obj.m_abbreviations, this.m_abbreviations);
> I didn't fix the warning here, cause it's not completely clear what you're trying to compare. Should the line for ClassPatter say:
> "areEqualsOrBothNull(Pattern.m_abbreviations, ClassPattern.m_abbreviations);" or "areEqualsOrBothNull(ClassPattern.m_abbreviations, ClassPattern.m_abbreviations);" ?
> Using the correct static test, would make it more clear. And if the last case is the right one, then the test doesn't really make sense or does it?
> /Jeppe

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email