Re: Is the Checkstyle project inter ested in a Log4J Best Practice checker?

Klaus-Peter Berg <[email protected]> Thu, 18 Dec 2008 12:57:54 +0100
Newsgroups gmane.comp.java.audit.checkstyle.user
Organization http://freemail.web.de/
Message-ID <[email protected]>
Hi Oliver,

yes, I have studied "http://checkstyle.sourceforge.net/contributing.html" ;-)

I know that the Checkstyle team is strongly committed to quality and I think that I'm on the same way too.
First, I have written a corresponding JUnit 3.8.x test that runs within the Checkstyle 4.4 test framework and that makes use of
"testInputFilePath = getPath("coding" + File.separator + "InputLogging.java");", i.e., that is using a specific test file in your "testinputs.dir".
I'm also checking my source code  with Eclipse rules, FindBugs and Enerjy. Checkstyle will follow, of course ;-)
However, I have just started to get familiar with Emma, because I was using Clover and Cobertura in the past.
Sorry for the broken link at JavaWorld but I contained not much more that explaining the rationale for this kind of LoggingChecker.

--Klaus

> -----Ursprüngliche Nachricht-----
> Von: "Oliver Burn" <[email protected]>
> Gesendet: 18.12.08 11:21:43
> An: [email protected]
> Betreff: Re: [Checkstyle-user] Is the Checkstyle project interested in a Log4J Best Practice checker?

Hi,
> 
> I also interesting in finding out more. Your linkhttp://www.javaworld.
> com/community/node/1882 does not work.
> 
> What state is the code in - and have you readhttp://checkstyle.
> sourceforge.net/contributing.html ?
> 
> Cheers,
> Oliver
> 
> Jeff Jensen wrote:Great! I am wondering about a couple of things, if 
> you don't mind me asking... Are these individual checks, or one check 
> that does all? (I am wondering if we can disable one or more) With 
> the "Avoid using parameter construction within the logging request" 
> check, does it work with Slf4j's parametric logging? LOGGER.debug("
> value1={}, value2={}", value1, value2); That log message must not 
> fail the check with Slf4j (Slf4j does not call toString() on the 
> message parameters (value1, value2) if the level is not active), as 
> the message is a constant and the check should handle the additional 
> parameters. 
____________________________________________________________________
Psssst! Schon vom neuen WEB.DE MultiMessenger gehört? 
Der kann`s mit allen: http://www.produkte.web.de/messenger/?did=3123


------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/