Re: False report of AvoidInlineConditionals?
Oliver Burn <[email protected]> Sat, 17 Aug 2013 08:32:06 +1000
| Newsgroups | gmane.comp.java.audit.checkstyle.user |
|---|---|
| Message-ID | <CAHZftdWQy=TT1L5nYgvYCT3ZcUCg5jKc8fq-1GmQ_GyQvihUrA@mail.gmail.com> |
--===============2421700091704650078== Content-Type: multipart/alternative; boundary=20cf307cfec011915504e4182942 --20cf307cfec011915504e4182942 Content-Type: text/plain; charset=ISO-8859-1 Can you provide a complete sample Java file and configuration file demonstrating the problem. That would be a great help On 17 Aug 2013 01:06, <[email protected]> wrote: > I am seeing a false violation for AvoidInlineConditional, when using > Checkstyle 5.6.**** > > ** ** > > The java code that triggers the Checkstyle violation is:**** > > ** ** > > //This is a SQL statement and not an *inline* conditional**** > > *private* *static* *final* String NON_ADMIN_USER_QUERY =**** > > "INSERT INTO TEMP_PERMISSIONS (RESOURCE_ID) SELECT distinct " +*** > * > > "V_ENTITY_PERMISSION.ENTITY_ID FROM V_ENTITY_PERMISSION, %s > resource_table " +**** > > "where V_ENTITY_PERMISSION.ENTITY_ID = resource_table.%s " +**** > > "and V_ENTITY_PERMISSION.MEMBER_GUID in (%s) and > V_ENTITY_PERMISSION.ENTITY_TYPE = ? " +**** > > "and V_ENTITY_PERMISSION.ROLE <= ? and > resource_table.CUSTOMER_STORAGE_ID = ? " +**** > > "and resource_table.CUSTOMER_STORAGE_ID = > V_ENTITY_PERMISSION.CUSTOMER_STORAGE_ID " +**** > > "and V_ENTITY_PERMISSION.MEMBER_TYPE in (%s)";**** > > ** ** > > Is this a potential CheckStyle bug, or is there a way to configure > CheckStyle to avoid falsely reporting a violation for > AvoidInlineConditional?**** > > ** ** > > Mark C. Determan**** > > > ------------------------------------------------------------------------------ > Get 100% visibility into Java/.NET code with AppDynamics Lite! > It's a free troubleshooting tool designed for production. > Get down to code-level detail for bottlenecks, with <2% overhead. > Download for free and get started troubleshooting in minutes. > http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk > _______________________________________________ > Checkstyle-user mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/checkstyle-user > > --20cf307cfec011915504e4182942 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable <p dir=3D"ltr">Can you provide a complete sample Java file and configuratio= n file demonstrating the problem. That would be a great help </p> <div class=3D"gmail_quote">On 17 Aug 2013 01:06, <<a href=3D"mailto:mar= [email protected]">[email protected]</a>>= wrote:<br type=3D"attribution"><blockquote class=3D"gmail_quote" style=3D"= margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div lang=3D"EN-US" link=3D"blue" vlink=3D"purple"> <div> <p class=3D"MsoNormal">I am seeing a false violation for AvoidInlineConditi= onal, when using Checkstyle 5.6.<u></u><u></u></p> <p class=3D"MsoNormal"><u></u>=A0<u></u></p> <p class=3D"MsoNormal">The java code that triggers the Checkstyle violation= is:<u></u><u></u></p> <p class=3D"MsoNormal"><u></u>=A0<u></u></p> <p class=3D"MsoNormal" style=3D"text-autospace:none"><span style=3D"font-si= ze:10.0pt;font-family:Consolas">=A0=A0=A0 </span><span style=3D"font-size:10.0pt;font-family:Consolas;color:#3f7f5f">= //This is a SQL statement and not an <u>inline</u> conditional</span><span style=3D"font-size:10.0pt;font-family= :Consolas"><u></u><u></u></span></p> <p class=3D"MsoNormal" style=3D"text-autospace:none"><span style=3D"font-si= ze:10.0pt;font-family:Consolas">=A0=A0=A0 </span><b><span style=3D"font-size:10.0pt;font-family:Consolas;color:#7f005= 5">private</span></b><span style=3D"font-size:10.0pt;font-family:Consolas"> </span><b><span style=3D"font-size:10.0pt;font-family:Consolas;color:#7f005= 5">static</span></b><span style=3D"font-size:10.0pt;font-family:Consolas"> </span><b><span style=3D"font-size:10.0pt;font-family:Consolas;color:#7f005= 5">final</span></b><span style=3D"font-size:10.0pt;font-family:Consolas"> S= tring </span><span style=3D"font-size:10.0pt;font-family:Consolas;color:#6000a0">= NON_ADMIN_USER_QUERY</span><span style=3D"font-size:10.0pt;font-family:Cons= olas"> =3D</span><span style=3D"font-size:10.0pt;font-family:Consolas"><u><= /u><u></u></span></p> <p class=3D"MsoNormal" style=3D"text-autospace:none"><span style=3D"font-si= ze:10.0pt;font-family:Consolas">=A0=A0=A0=A0=A0=A0=A0 </span><span style=3D"font-size:10.0pt;font-family:Consolas;color:#2a00ff">= "INSERT INTO TEMP_PERMISSIONS (RESOURCE_ID) SELECT distinct "</sp= an><span style=3D"font-size:10.0pt;font-family:Consolas"> +</span><span sty= le=3D"font-size:10.0pt;font-family:Consolas"><u></u><u></u></span></p> <p class=3D"MsoNormal" style=3D"text-autospace:none"><span style=3D"font-si= ze:10.0pt;font-family:Consolas">=A0=A0=A0=A0=A0=A0=A0 </span><span style=3D"font-size:10.0pt;font-family:Consolas;color:#2a00ff">= "V_ENTITY_PERMISSION.ENTITY_ID FROM V_ENTITY_PERMISSION, %s resource_t= able "</span><span style=3D"font-size:10.0pt;font-family:Consolas"> +<= /span><span style=3D"font-size:10.0pt;font-family:Consolas"><u></u><u></u><= /span></p> <p class=3D"MsoNormal" style=3D"text-autospace:none"><span style=3D"font-si= ze:10.0pt;font-family:Consolas">=A0=A0=A0=A0=A0=A0=A0 </span><span style=3D"font-size:10.0pt;font-family:Consolas;color:#2a00ff">= "where V_ENTITY_PERMISSION.ENTITY_ID =3D resource_table.%s "</spa= n><span style=3D"font-size:10.0pt;font-family:Consolas"> +</span><span styl= e=3D"font-size:10.0pt;font-family:Consolas"><u></u><u></u></span></p> <p class=3D"MsoNormal" style=3D"text-autospace:none"><span style=3D"backgro= und:red;font-size:10.0pt;font-family:Consolas">=A0=A0=A0=A0=A0=A0=A0 </span><span style=3D"font-size:10.0pt;font-family:Consolas;color:#2a00ff;b= ackground:red">"and V_ENTITY_PERMISSION.MEMBER_GUID in (%s) and V_ENTI= TY_PERMISSION.ENTITY_TYPE =3D ? "</span><span style=3D"background:red;= font-size:10.0pt;font-family:Consolas"> +</span><span style=3D"font-size:10.0pt;font-family:Consolas"><u></u><u></= u></span></p> <p class=3D"MsoNormal" style=3D"text-autospace:none"><span style=3D"font-si= ze:10.0pt;font-family:Consolas">=A0=A0=A0=A0=A0=A0=A0 </span><span style=3D"font-size:10.0pt;font-family:Consolas;color:#2a00ff">= "and V_ENTITY_PERMISSION.ROLE <=3D ? and resource_table.CUSTOMER_ST= ORAGE_ID =3D ? "</span><span style=3D"font-size:10.0pt;font-family:Con= solas"> +</span><span style=3D"font-size:10.0pt;font-family:Consolas"><u></= u><u></u></span></p> <p class=3D"MsoNormal" style=3D"text-autospace:none"><span style=3D"font-si= ze:10.0pt;font-family:Consolas">=A0=A0=A0=A0=A0=A0=A0 </span><span style=3D"font-size:10.0pt;font-family:Consolas;color:#2a00ff">= "and resource_table.CUSTOMER_STORAGE_ID =3D V_ENTITY_PERMISSION.CUSTOM= ER_STORAGE_ID "</span><span style=3D"font-size:10.0pt;font-family:Cons= olas"> +</span><span style=3D"font-size:10.0pt;font-family:Consolas"><u></u= ><u></u></span></p> <p class=3D"MsoNormal" style=3D"text-autospace:none"><span style=3D"font-si= ze:10.0pt;font-family:Consolas">=A0=A0=A0=A0=A0=A0=A0 </span><span style=3D"font-size:10.0pt;font-family:Consolas;color:#2a00ff">= "and V_ENTITY_PERMISSION.MEMBER_TYPE in (%s)"</span><span style= =3D"font-size:10.0pt;font-family:Consolas">;</span><span style=3D"font-size= :10.0pt;font-family:Consolas"><u></u><u></u></span></p> <p class=3D"MsoNormal" style=3D"text-autospace:none"><span style=3D"font-si= ze:10.0pt;font-family:Consolas"><u></u>=A0<u></u></span></p> <p class=3D"MsoNormal">Is this a potential CheckStyle bug, or is there a wa= y to configure CheckStyle to avoid falsely reporting a violation for AvoidI= nlineConditional?<u></u><u></u></p> <p class=3D"MsoNormal"><u></u>=A0<u></u></p> <p class=3D"MsoNormal">Mark C. Determan<u></u><u></u></p> </div> </div> <br>-----------------------------------------------------------------------= -------<br> Get 100% visibility into Java/.NET code with AppDynamics Lite!<br> It's a free troubleshooting tool designed for production.<br> Get down to code-level detail for bottlenecks, with <2% overhead.<br> Download for free and get started troubleshooting in minutes.<br> <a href=3D"http://pubads.g.doubleclick.net/gampad/clk?id=3D48897031&iu= =3D/4140/ostg.clktrk" target=3D"_blank">http://pubads.g.doubleclick.net/gam= pad/clk?id=3D48897031&iu=3D/4140/ostg.clktrk</a><br>___________________= ____________________________<br> Checkstyle-user mailing list<br> <a href=3D"mailto:[email protected]">Checkstyle-user@li= sts.sourceforge.net</a><br> <a href=3D"https://lists.sourceforge.net/lists/listinfo/checkstyle-user" ta= rget=3D"_blank">https://lists.sourceforge.net/lists/listinfo/checkstyle-use= r</a><br> <br></blockquote></div> --20cf307cfec011915504e4182942-- --===============2421700091704650078== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk --===============2421700091704650078== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Checkstyle-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/checkstyle-user --===============2421700091704650078==--