Re: Error in checkstyle contrib checkstyle-noframes-sorted.xsl

Hi Xavier,

thanks for your proposed fix. In fact what you see is a symptom of bug
1616905 "Double entry in the xml report for one source file", once
that is fixed your problem will go away. I will not commit your
proposed change, because as you say this does not fix the problem
consistently and create unnecessary complexity once the original bug
is resolved.

Thanks for sending a partial fix anyway. Having it in the list
archives might help users who encounter the same problem now, and of
course we appreciate users who dig into the code and send fixes for
the issues they encounter.

Cheers,
Lars

On 1/29/07, Xavier Outhier wrote:
> Hi all,
>
> I've downloaded Checkstyle 4.3.
> I've found an error in checkstyle-noframes-sorted.xsl in contrib dir.
> The problem is that in the output file, there are (at least with my
> configaration) several <file> tag (indeed 2 per java file) and that the
> merge for counting the <error> tags doesn't work.
>
> Here is the fix:
>
> replace
>                 <xsl:variable name="errorCount" select="error"/>
> with
>                 <xsl:variable name="errorCount"
> select="count(key('files', @name)/error)"/>
> in template     <xsl:template match="checkstyle" mode="filelist">.
>
>
> There is a similar but that apply for all sections: summary (twice more
> files),
> files (no merge but correct) and individual (no merge but correct). Sorry
> I'm not able rapidley to find a fix for it!
>
> Cheers,
>
> Xavier.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642