Re: Issue with FASTA reader
Jose Duarte <[email protected]> Thu, 1 Jun 2017 09:36:52 -0500
| Newsgroups | gmane.comp.java.bio.general |
|---|---|
| Message-ID | <CAHhO=JEdA04ERCjdCsYHVH+tjVAtq5B0Dren=-A31uRjhDcjMQ@mail.gmail.com> |
--===============6411009389403701323== Content-Type: multipart/alternative; boundary="001a11472ba0ca6a2c0550e6f78e" --001a11472ba0ca6a2c0550e6f78e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear Dak The best way of fixing it yourself is that you modify the code in your own github fork (ideally in a branch, not in master) and then submit a pull request so that your patch can be peer reviewed. All the best Jose On Thu, Jun 1, 2017 at 8:25 AM, Rojnuckarin, Dak <[email protected]> wrote: > Hello, > > > > Andreas mentioned he created a branch in github to contain my test code: > > > > https://github.com/biojava/biojava/commit/9de8e3633a8d66fc4050f14b2e2168 > 4605cf2f7b > > > > but I have not heard back in a while. > > > > What=E2=80=99s the process/etiquette of getting involved and attempt the = fix > myself? > > > > Thanks, > > dak > > > > *From:* [email protected] [mailto:[email protected]] *On > Behalf Of *Andreas Prlic > *Sent:* Wednesday, April 19, 2017 4:34 PM > *To:* Rojnuckarin, Dak <[email protected]> > *Cc:* [email protected] > *Subject:* Re: [Biojava-l] Issue with FASTA reader > > > > Thanks, Dak. I'll create a branch in git which will contain your test, > then we can take it from there. > > > > Andreas > > > > > > > > On Mon, Apr 17, 2017 at 9:43 AM, Rojnuckarin, Dak <[email protected]> > wrote: > > Hi, > > > > I have a FASTA file that contain one sequence. I initialized FASTA reader > as described in the tutorial, called process() and get one record as > expected. However, if I re-initialized another FASTA reader opening the > same one-record file, called process(1) and null is returned. If I tried = to > read two-record FASTA file, the first process(1) works, but not the secon= d > call to process(1) return null. Based on a superficial glance, it looks > like the if statement at line 194 of FastaReader.java may be the culprit. > > > > Test code attached. > > > > Thanks, > > Dak Rojnuckarin > > Research Informatics > > Amgen > > > > > > > _______________________________________________ > Biojava-l mailing list - [email protected] > http://mailman.open-bio.org/mailman/listinfo/biojava-l > > > > > > -- > > ----------------------------------------------------------------------- > Dr. Andreas Prlic > RCSB PDB Protein Data Bank > > Technical & Scientific Team Lead > > University of California, San Diego > > > > Editor Software Section > > PLOS Computational Biology > > > > BioJava Project Lead > ----------------------------------------------------------------------- > > _______________________________________________ > Biojava-l mailing list - [email protected] > http://mailman.open-bio.org/mailman/listinfo/biojava-l > --001a11472ba0ca6a2c0550e6f78e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Dear Dak<div><br></div><div>The best way of fixing it your= self is that you modify the code in your own github fork (ideally in a bran= ch, not in master) and then submit a pull request so that your patch can be= peer reviewed.</div><div><br></div><div>All the best</div><div><br></div><= div>Jose</div><div><br></div></div><div class=3D"gmail_extra"><br><div clas= s=3D"gmail_quote">On Thu, Jun 1, 2017 at 8:25 AM, Rojnuckarin, Dak <span di= r=3D"ltr"><<a href=3D"mailto:[email protected]" target=3D"_blank">atipat= [email protected]</a>></span> wrote:<br><blockquote class=3D"gmail_quote" styl= e=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div lang=3D"EN-US" link=3D"blue" vlink=3D"purple"> <div class=3D"m_7996673485842828688WordSection1"> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt;font-family:"Ca= libri",sans-serif;color:#1f497d">Hello,<u></u><u></u></span></p> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt;font-family:"Ca= libri",sans-serif;color:#1f497d"><u></u>=C2=A0<u></u></span></p> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt;font-family:"Ca= libri",sans-serif;color:#1f497d">Andreas mentioned he created a branch= in github to contain my test code:<u></u><u></u></span></p> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt;font-family:"Ca= libri",sans-serif;color:#1f497d"><u></u>=C2=A0<u></u></span></p> <p class=3D"MsoNormal"><a href=3D"https://github.com/biojava/biojava/commit= /9de8e3633a8d66fc4050f14b2e21684605cf2f7b" target=3D"_blank">https://github= .com/biojava/<wbr>biojava/commit/<wbr>9de8e3633a8d66fc4050f14b2e2168<wbr>46= 05cf2f7b</a><u></u><u></u></p> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt;font-family:"Ca= libri",sans-serif;color:#1f497d"><u></u>=C2=A0<u></u></span></p> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt;font-family:"Ca= libri",sans-serif;color:#1f497d">but I have not heard back in a while. <u></u><u></u></span></p> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt;font-family:"Ca= libri",sans-serif;color:#1f497d"><u></u>=C2=A0<u></u></span></p> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt;font-family:"Ca= libri",sans-serif;color:#1f497d">What=E2=80=99s the process/etiquette = of getting involved and attempt the fix myself?<u></u><u></u></span></p> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt;font-family:"Ca= libri",sans-serif;color:#1f497d"><u></u>=C2=A0<u></u></span></p> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt;font-family:"Ca= libri",sans-serif;color:#1f497d">Thanks,<u></u><u></u></span></p> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt;font-family:"Ca= libri",sans-serif;color:#1f497d">dak<u></u><u></u></span></p> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt;font-family:"Ca= libri",sans-serif;color:#1f497d"><u></u>=C2=A0<u></u></span></p> <p class=3D"MsoNormal"><b><span style=3D"font-size:11.0pt;font-family:"= ;Calibri",sans-serif">From:</span></b><span style=3D"font-size:11.0pt;= font-family:"Calibri",sans-serif"> <a href=3D"mailto:andreas.prli= [email protected]" target=3D"_blank">[email protected]</a> [mailto:<a href= =3D"mailto:[email protected]" target=3D"_blank">andreas.prlic@gmail.<= wbr>com</a>] <b>On Behalf Of </b>Andreas Prlic<br> <b>Sent:</b> Wednesday, April 19, 2017 4:34 PM<br> <b>To:</b> Rojnuckarin, Dak <<a href=3D"mailto:[email protected]" target= =3D"_blank">[email protected]</a>><br> <b>Cc:</b> <a href=3D"mailto:[email protected]" target=3D"_bla= nk">[email protected]</a><br> <b>Subject:</b> Re: [Biojava-l] Issue with FASTA reader<u></u><u></u></span= ></p><div><div class=3D"h5"> <p class=3D"MsoNormal"><u></u>=C2=A0<u></u></p> <div> <p class=3D"MsoNormal">Thanks, Dak. I'll create a branch in git which w= ill contain your test, then we can take it from there.<u></u><u></u></p> <div> <p class=3D"MsoNormal"><u></u>=C2=A0<u></u></p> </div> <div> <p class=3D"MsoNormal">Andreas<u></u><u></u></p> <div> <p class=3D"MsoNormal"><u></u>=C2=A0<u></u></p> </div> <div> <p class=3D"MsoNormal"><u></u>=C2=A0<u></u></p> </div> </div> </div> <div> <p class=3D"MsoNormal"><u></u>=C2=A0<u></u></p> <div> <p class=3D"MsoNormal">On Mon, Apr 17, 2017 at 9:43 AM, Rojnuckarin, Dak &l= t;<a href=3D"mailto:[email protected]" target=3D"_blank">[email protected]<= /a>> wrote:<u></u><u></u></p> <blockquote style=3D"border:none;border-left:solid #cccccc 1.0pt;padding:0i= n 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> <div> <div> <p class=3D"MsoNormal">Hi,<u></u><u></u></p> <p class=3D"MsoNormal">=C2=A0<u></u><u></u></p> <p class=3D"MsoNormal">I have a FASTA file that contain one sequence. I ini= tialized FASTA reader as described in the tutorial, called process() and ge= t one record as expected. However, if I re-initialized another FASTA reader opening the same one-record file, called process(1) a= nd null is returned. If I tried to read two-record FASTA file, the first pr= ocess(1) works, but not the second call to process(1) return null. Based on= a superficial glance, it looks like the if statement at line 194 of FastaReader.java may be the culprit. = <u></u><u></u></p> <p class=3D"MsoNormal">=C2=A0<u></u><u></u></p> <p class=3D"MsoNormal">Test code attached.<u></u><u></u></p> <p class=3D"MsoNormal">=C2=A0<u></u><u></u></p> <p class=3D"MsoNormal">Thanks,<u></u><u></u></p> <p class=3D"MsoNormal">Dak Rojnuckarin<u></u><u></u></p> <p class=3D"MsoNormal">Research Informatics<u></u><u></u></p> <p class=3D"MsoNormal">Amgen<u></u><u></u></p> <p class=3D"MsoNormal">=C2=A0<u></u><u></u></p> <p class=3D"MsoNormal">=C2=A0=C2=A0<u></u><u></u></p> </div> </div> <p class=3D"MsoNormal"><br> ______________________________<wbr>_________________<br> Biojava-l mailing list=C2=A0 -=C2=A0 <a href=3D"mailto:[email protected]= en-bio.org" target=3D"_blank">[email protected]</a><br> <a href=3D"http://mailman.open-bio.org/mailman/listinfo/biojava-l" target= =3D"_blank">http://mailman.open-bio.org/<wbr>mailman/listinfo/biojava-l</a>= <u></u><u></u></p> </blockquote> </div> <p class=3D"MsoNormal"><br> <br clear=3D"all"> <u></u><u></u></p> <div> <p class=3D"MsoNormal"><u></u>=C2=A0<u></u></p> </div> <p class=3D"MsoNormal">-- <u></u><u></u></p> <div> <div> <div> <div> <p class=3D"MsoNormal">------------------------------<wbr>-----------------= -------------<wbr>-----------<br> Dr. Andreas Prlic<br> RCSB PDB Protein Data Bank<u></u><u></u></p> </div> <div> <p class=3D"MsoNormal">Technical & Scientific Team Lead<u></u><u></u></= p> </div> <div> <p class=3D"MsoNormal">University of California, San Diego<u></u><u></u></p= > <div> <p class=3D"MsoNormal"><u></u>=C2=A0<u></u></p> </div> <div> <p class=3D"MsoNormal">Editor Software Section=C2=A0<u></u><u></u></p> <div> <p class=3D"MsoNormal">PLOS Computational Biology<u></u><u></u></p> <div> <div> <div> <p class=3D"MsoNormal"><u></u>=C2=A0<u></u></p> </div> <div> <p class=3D"MsoNormal">BioJava Project Lead<br> ------------------------------<wbr>------------------------------<wbr>-----= ------<u></u><u></u></p> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div></div></div> </div> <br>______________________________<wbr>_________________<br> Biojava-l mailing list=C2=A0 -=C2=A0 <a href=3D"mailto:[email protected]= en-bio.org">[email protected]</a><br> <a href=3D"http://mailman.open-bio.org/mailman/listinfo/biojava-l" rel=3D"n= oreferrer" target=3D"_blank">http://mailman.open-bio.org/<wbr>mailman/listi= nfo/biojava-l</a><br></blockquote></div><br></div> --001a11472ba0ca6a2c0550e6f78e-- --===============6411009389403701323== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Biojava-l mailing list - [email protected] http://mailman.open-bio.org/mailman/listinfo/biojava-l --===============6411009389403701323==--