Re: [VOTE] Cayenne 4.1.B1 release

My evaluation was successful, except for a few minor things:

1. Modeler "About" dialog still has 2018 as copyright year (certainly not a blocker for the release).
2. Scalar SQLSelect used to be able to fetch values with abstract Number class as a root. Now it fails with the exception below [1].

-        Number result = SQLSelect.scalarQuery(Number.class, "SELECT COUNT(1) FROM T1").selectOne(newContext());
+        Number result = SQLSelect.scalarQuery(Integer.class, "SELECT COUNT(1) FROM T1").selectOne(newContext());

I have an easy fix in the consuming code and I don't particularly care about this case (abstract value objects), but I wonder if this change of behavior is an indicator of a deeper problem somewhere?

Thanks,
Andrus


[1] java.sql.SQLDataException: An attempt was made to get a data value of type 'byte[]' from a data value of type 'INTEGER'.
	at org.apache.derby.impl.jdbc.SQLExceptionFactory40.getSQLException(Unknown Source)
	at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown Source)
	at org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown Source)
	at org.apache.derby.impl.jdbc.EmbedResultSet.noStateChangeException(Unknown Source)
	at org.apache.derby.impl.jdbc.EmbedResultSet.getBytes(Unknown Source)
	at org.apache.cayenne.access.types.ByteArrayType.materializeObject(ByteArrayType.java:108)
	at org.apache.cayenne.access.types.ByteArrayType.materializeObject(ByteArrayType.java:40)
	at org.apache.cayenne.access.types.ExtendedTypeDecorator.materializeObject(ExtendedTypeDecorator.java:53)
	at org.apache.cayenne.access.jdbc.reader.ScalarRowReader.readRow(ScalarRowReader.java:50)
	at org.apache.cayenne.access.jdbc.JDBCResultIterator.nextRow(JDBCResultIterator.java:104)
	...
	at org.apache.cayenne.BaseContext.selectOne(BaseContext.java:315)
	at org.apache.cayenne.query.SQLSelect.selectOne(SQLSelect.java:217)

> On Mar 7, 2019, at 4:23 PM, Nikita Timofeev <[email protected]> wrote:
> 
> Uploaded fixed version:
> 
> Maven repo: https://repository.apache.org/content/repositories/orgapachecayenne-1028/
> Assemblies: https://dist.apache.org/repos/dist/dev/cayenne/4.1.B1/
> 
> On Thu, Mar 7, 2019 at 1:44 PM Nikita Timofeev
> <[email protected]> wrote:
>> 
>> I think I can just redo this release. It's better be safe than sorry.
>> 
>> On Thu, Mar 7, 2019 at 6:01 AM John Huss <[email protected]> wrote:
>>> 
>>> If it's needed at runtime as a dependency it should be bundled. I still
>>> prefer to manually manage jar dependencies most of the time.
>>> On Wed, Mar 6, 2019 at 5:51 PM Aristedes Maniatis <[email protected]> wrote:
>>> 
>>>> What is the general Apache consensus about bundling third party
>>>> libraries? In an age where everyone is accessing libraries from maven
>>>> co-ordinates, is it necessary to include any of them at all? I'd be
>>>> surprised if a single person used them ever from our zip. We aren't
>>>> signing them or providing any oversight of their contents.
>>>> 
>>>> 
>>>> Ari
>>>> 
>>>> 
>>>> On 5/3/19 12:18am, Andrus Adamchik wrote:
>>>>> Good catch. I guess since this is a dependency that can be easily
>>>> downloaded from the internet, we can let it slip for now and proceed with
>>>> the release (and fix it in the next release). Does anyone feel strongly
>>>> about this one?
>>>>> 
>>>>> Andrus
>>>>> 
>>>>> 
>>>>>> On Mar 1, 2019, at 7:32 PM, John Huss <[email protected]> wrote:
>>>>>> 
>>>>>> The windows zip doesn't include the file
>>>>>> "lib/third-party/slf4j-api-1.7.25.jar" which the mac one does.
>>>>>> 
>>>>>> Otherwise it looks good.
>>>>>> 
>>>>>> On Fri, Mar 1, 2019 at 5:28 AM Nikita Timofeev <
>>>> [email protected]>
>>>>>> wrote:
>>>>>> 
>>>>>>> Hi all,
>>>>>>> 
>>>>>>> Here is long-promised 4.1 beta release with lots of fixes and some
>>>>>>> minor features.
>>>>>>> 
>>>>>>> Release notes:
>>>>>>> https://github.com/apache/cayenne/blob/4.1.B1/RELEASE-NOTES.txt
>>>>>>> Maven repo:
>>>>>>> 
>>>> https://repository.apache.org/content/repositories/orgapachecayenne-1028/
>>>>>>> Assemblies: https://dist.apache.org/repos/dist/dev/cayenne/4.1.B1/
>>>>>>> 
>>>>>>> Please evaluate it and cast your votes.
>>>>>>> 
>>>>>>> --
>>>>>>> Best regards,
>>>>>>> Nikita Timofeev
>>>>>>> 
>>>> 
>> 
>> 
>> 
>> --
>> Best regards,
>> Nikita Timofeev
> 
> 
> 
> -- 
> Best regards,
> Nikita Timofeev