[commit-cp] classpath ChangeLog java/util/HashMap.java

Pekka Enberg <[email protected]> Sun, 30 Oct 2011 07:36:39 +0000
Newsgroups gmane.comp.java.classpath.cvs
Message-ID <[email protected]>
CVSROOT:	/sources/classpath
Module name:	classpath
Changes by:	Pekka Enberg <penberg>	11/10/30 07:36:39

Modified files:
	.              : ChangeLog 
	java/util      : HashMap.java 

Log message:
	Stefan Ring reports that commit f154af6 ("Fix HashMap.put() to check for
	hashCode equality before equals()") breaks running the CACAO test suite.  The
	breakage looks like this:
	
	  LD_LIBRARY_PATH=../../../src/cacao/.libs ../../../src/cacao/cacao -Xbootclasspath:../../../src/classes/classes:/home/sr/classpathcvs/share/classpath/glibj.zip -classpath /usr/share/java/junit4.jar:. org.junit.runner.JUnitCore All
	  JUnit version 4.5
	  .E
	  Time: 0.003
	  There was 1 failure:
	  1) initializationError(All)
	  java.lang.NullPointerException
	     at java.util.HashMap.put(HashMap.java:348)
	     at java.util.HashSet.add(HashSet.java:151)
	     at org.junit.runners.model.RunnerBuilder.addParent(RunnerBuilder.java:64)
	     at org.junit.runners.model.RunnerBuilder.runners(RunnerBuilder.java:81)
	     at org.junit.runners.Suite.<init>(Suite.java:88)
	     at org.junit.runners.Suite.<init>(Suite.java:54)
	     at java.lang.reflect.VMConstructor.construct(Native Method)
	     at java.lang.reflect.Constructor.newInstance(Constructor.java:318)
	     at org.junit.internal.builders.AnnotatedBuilder.buildRunner(AnnotatedBuilder.java:35)
	     at org.junit.internal.builders.AnnotatedBuilder.runnerForClass(AnnotatedBuilder.java:24)
	     at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:57)
	     at org.junit.internal.builders.AllDefaultPossibilitiesBuilder.runnerForClass(AllDefaultPossibilitiesBuilder.java:29)
	     at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:57)
	     at org.junit.runners.model.RunnerBuilder.runners(RunnerBuilder.java:93)
	     at org.junit.runners.model.RunnerBuilder.runners(RunnerBuilder.java:84)
	     at org.junit.runners.Suite.<init>(Suite.java:66)
	     at org.junit.runner.Request.classes(Request.java:68)
	     at org.junit.runner.JUnitCore.run(JUnitCore.java:107)
	     at org.junit.runner.JUnitCore.runMain(JUnitCore.java:88)
	     at org.junit.runner.JUnitCore.runMainAndExit(JUnitCore.java:54)
	     at org.junit.runner.JUnitCore.main(JUnitCore.java:46)
	
	  FAILURES!!!
	  Tests run: 1,  Failures: 1
	
	Looking at the code, it's obviously broken for HashMap.put() with a null key.
	
	2011-10-24  Pekka Enberg  <[email protected]>
	
	        * java/util/HashMap.java:
	        (put): Fix NullPointerException for null keys.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpath&r1=1.9832&r2=1.9833
http://cvs.savannah.gnu.org/viewcvs/classpath/java/util/HashMap.java?cvsroot=classpath&r1=1.37&r2=1.38