Re: [PATCH] Honour CPNIO_DSYNC flag if set.
Guillermo Rodriguez Garcia <[email protected]> Tue, 2 Feb 2016 16:52:47 +0100
| Newsgroups | gmane.comp.java.classpath.devel |
|---|---|
| Message-ID | <CABDcavaHfoGGrqZhgBk=h-ZhDLzQcuL7vLcT7f45zFMkuZTn0g@mail.gmail.com> |
--001a1144278a358ea5052acb7ef3 Content-Type: text/plain; charset=UTF-8 Hello Andrew, Any chances this patch and the DecimalFormat one will be applied? It is been roughly one year since I first submitted the patches. Guillermo 2015-07-28 16:46 GMT+02:00 Andrew Hughes <[email protected]>: > ----- Original Message ----- > > Hello, > > > > Don't want to bug you, but have you had the chance to look into this? > > > > Hi Guillermo, > > Sorry, I've been busy with the OpenJDK security updates. > I'll try and look into both this week. > > Thanks for your patience. > > > Guillermo > > > > 2015-01-29 18:16 GMT+01:00 Andrew Hughes <[email protected]>: > > > > > > > > > ----- Original Message ----- > > >> Hello. Any feedback? > > >> > > >> > > >> 2015-01-20 14:10 GMT+01:00 grodriguez <[email protected]>: > > >> > > >> > The CPNIO_DSYNC flag was being ignored (only CPNIO_SYNC was > honoured). > > >> > This was breaking at least RandomFileAccess when open in "rwd" mode > > >> > ("rws" would work as expected). > > >> > > > >> > --- > > >> > native/jni/java-nio/gnu_java_nio_VMChannel.c | 3 ++- > > >> > 1 files changed, 2 insertions(+), 1 deletions(-) > > >> > > > >> > diff --git a/native/jni/java-nio/gnu_java_nio_VMChannel.c > > >> > b/native/jni/java-nio/gnu_java_nio_VMChannel.c > > >> > index 7899f0b..6a1cf48 100644 > > >> > --- a/native/jni/java-nio/gnu_java_nio_VMChannel.c > > >> > +++ b/native/jni/java-nio/gnu_java_nio_VMChannel.c > > >> > @@ -1705,7 +1705,8 @@ Java_gnu_java_nio_VMChannel_open (JNIEnv *env, > > >> > | ((mode & CPNIO_APPEND) ? O_APPEND : > > >> > ((nmode == O_WRONLY) ? O_TRUNC : 0)) > > >> > | ((mode & CPNIO_EXCL) ? O_EXCL : 0) > > >> > - | ((mode & CPNIO_SYNC) ? O_SYNC : 0)); > > >> > + | ((mode & CPNIO_SYNC) ? O_SYNC : 0) > > >> > + | ((mode & CPNIO_DSYNC) ? O_DSYNC : 0)); > > >> > > > >> > npath = JCL_jstring_to_cstring (env, path); > > >> > > > >> > -- > > >> > 1.7.0.4 > > >> > > > >> > > > >> > > >> > > >> -- > > >> Guillermo Rodriguez Garcia > > >> [email protected] > > >> > > > > > > Thanks. I'll apply the patch as soon as I can. > > > -- > > > Andrew :) > > > > > > Free Java Software Engineer > > > Red Hat, Inc. (http://www.redhat.com) > > > > > > PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) > > > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > > > > > > PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) > > > Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 > > > > > > > > > > > -- > > Guillermo Rodriguez Garcia > > [email protected] > > > > > > -- > Andrew :) > > Senior Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > > PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) > Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 > > -- Guillermo Rodriguez Garcia [email protected] --001a1144278a358ea5052acb7ef3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Hello Andrew,<div><br></div><div>Any chances this patch an= d the DecimalFormat one will be applied? It is been</div><div>roughly one y= ear since I first submitted the patches.</div><div><br></div><div>Guillermo= </div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">2015-07-28 = 16:46 GMT+02:00 Andrew Hughes <span dir=3D"ltr"><<a href=3D"mailto:gnu.a= [email protected]" target=3D"_blank">[email protected]</a>></span>:<b= r><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:= 1px #ccc solid;padding-left:1ex"><span class=3D"">----- Original Message --= ---<br> > Hello,<br> ><br> > Don't want to bug you, but have you had the chance to look into th= is?<br> ><br> <br> </span>Hi Guillermo,<br> <br> Sorry, I've been busy with the OpenJDK security updates.<br> I'll try and look into both this week.<br> <br> Thanks for your patience.<br> <div class=3D"HOEnZb"><div class=3D"h5"><br> > Guillermo<br> ><br> > 2015-01-29 18:16 GMT+01:00 Andrew Hughes <<a href=3D"mailto:gnu.and= [email protected]">[email protected]</a>>:<br> > ><br> > ><br> > > ----- Original Message -----<br> > >> Hello. Any feedback?<br> > >><br> > >><br> > >> 2015-01-20 14:10 GMT+01:00 grodriguez <<a href=3D"mailto:g= [email protected]">[email protected]</a>>:<br> > >><br> > >> > The CPNIO_DSYNC flag was being ignored (only CPNIO_SYNC = was honoured).<br> > >> > This was breaking at least RandomFileAccess when open in= "rwd" mode<br> > >> > ("rws" would work as expected).<br> > >> ><br> > >> > ---<br> > >> >=C2=A0 native/jni/java-nio/gnu_java_nio_VMChannel.c |=C2= =A0 =C2=A0 3 ++-<br> > >> >=C2=A0 1 files changed, 2 insertions(+), 1 deletions(-)<b= r> > >> ><br> > >> > diff --git a/native/jni/java-nio/gnu_java_nio_VMChannel.= c<br> > >> > b/native/jni/java-nio/gnu_java_nio_VMChannel.c<br> > >> > index 7899f0b..6a1cf48 100644<br> > >> > --- a/native/jni/java-nio/gnu_java_nio_VMChannel.c<br> > >> > +++ b/native/jni/java-nio/gnu_java_nio_VMChannel.c<br> > >> > @@ -1705,7 +1705,8 @@ Java_gnu_java_nio_VMChannel_open (= JNIEnv *env,<br> > >> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| ((mode = & CPNIO_APPEND) ? O_APPEND :<br> > >> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (= (nmode =3D=3D O_WRONLY) ? O_TRUNC : 0))<br> > >> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| ((mode = & CPNIO_EXCL) ? O_EXCL : 0)<br> > >> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| ((mode &= CPNIO_SYNC) ? O_SYNC : 0));<br> > >> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| ((mode &= CPNIO_SYNC) ? O_SYNC : 0)<br> > >> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| ((mode &= CPNIO_DSYNC) ? O_DSYNC : 0));<br> > >> ><br> > >> >=C2=A0 =C2=A0 npath =3D JCL_jstring_to_cstring (env, path= );<br> > >> ><br> > >> > --<br> > >> > 1.7.0.4<br> > >> ><br> > >> ><br> > >><br> > >><br> > >> --<br> > >> Guillermo Rodriguez Garcia<br> > >> <a href=3D"mailto:[email protected]">guille.rodrigue= [email protected]</a><br> > >><br> > ><br> > > Thanks. I'll apply the patch as soon as I can.<br> > > --<br> > > Andrew :)<br> > ><br> > > Free Java Software Engineer<br> > > Red Hat, Inc. (<a href=3D"http://www.redhat.com" rel=3D"noreferre= r" target=3D"_blank">http://www.redhat.com</a>)<br> > ><br> > > PGP Key: ed25519/35964222 (hkp://<a href=3D"http://keys.gnupg.net= " rel=3D"noreferrer" target=3D"_blank">keys.gnupg.net</a>)<br> > > Fingerprint =3D 5132 579D D154 0ED2 3E04=C2=A0 C5A0 CFDA 0F9B 359= 6 4222<br> > ><br> > > PGP Key: rsa4096/248BDC07 (hkp://<a href=3D"http://keys.gnupg.net= " rel=3D"noreferrer" target=3D"_blank">keys.gnupg.net</a>)<br> > > Fingerprint =3D EC5A 1F5E C0AD 1D15 8F1F=C2=A0 8F91 3B96 A578 248= B DC07<br> > ><br> ><br> ><br> ><br> > --<br> > Guillermo Rodriguez Garcia<br> > <a href=3D"mailto:[email protected]">[email protected]= om</a><br> ><br> ><br> <br> </div></div><span class=3D"HOEnZb"><font color=3D"#888888">--<br> Andrew :)<br> <br> Senior Free Java Software Engineer<br> </font></span><div class=3D"HOEnZb"><div class=3D"h5">Red Hat, Inc. (<a hre= f=3D"http://www.redhat.com" rel=3D"noreferrer" target=3D"_blank">http://www= .redhat.com</a>)<br> <br> PGP Key: ed25519/35964222 (hkp://<a href=3D"http://keys.gnupg.net" rel=3D"n= oreferrer" target=3D"_blank">keys.gnupg.net</a>)<br> Fingerprint =3D 5132 579D D154 0ED2 3E04=C2=A0 C5A0 CFDA 0F9B 3596 4222<br> <br> PGP Key: rsa4096/248BDC07 (hkp://<a href=3D"http://keys.gnupg.net" rel=3D"n= oreferrer" target=3D"_blank">keys.gnupg.net</a>)<br> Fingerprint =3D EC5A 1F5E C0AD 1D15 8F1F=C2=A0 8F91 3B96 A578 248B DC07<br> <br> </div></div></blockquote></div><br><br clear=3D"all"><div><br></div>-- <br>= <div class=3D"gmail_signature">Guillermo Rodriguez Garcia<br><a href=3D"mai= lto:[email protected]" target=3D"_blank">[email protected]= m</a></div> </div></div> --001a1144278a358ea5052acb7ef3--