Re: bug in MimeTypeParameterList

Archit Shah <[email protected]> Wed, 10 May 2006 15:09:21 -0400
Newsgroups gmane.comp.java.classpath.extensions.discuss
Message-ID <[email protected]>
This bug fix has been applied to the trunk. JOnAS needs an activation 
implementation corresponding to the JAF1.0.x/J2EE1.4 version of the 
spec. Would it be possible to apply the same patch to the 1.0.x branch 
and tag a release there? Objectweb would use this activation release for 
future 4.7.x and 4.8.x releases of JOnAS. AFAICT, there have been no 
other bug fixes on the trunk since the introduction of the JAF1.1 code.

  -- Archit

Archit Shah wrote:
> The following patch fixes the bug by forcing a non-empty 
> MimeTypeParameterList to start with ';' as indicated by the grammar in 
> RFC2045.
> 
> diff -u -r1.6 MimeTypeParameterList.java
> --- source/javax/activation/MimeTypeParameterList.java  25 Aug 2005
> +++ source/javax/activation/MimeTypeParameterList.java  24 Apr 2006
> @@ -231,11 +231,8 @@
>          String name = (String)i.next();
>          String value = (String)parameterValues.get(name.toLowerCase());
> 
> -        if (buffer.length() > 0)
> -          {
> -            buffer.append(';');
> -            buffer.append(' ');
> -          }
> +        buffer.append(';');
> +        buffer.append(' ');
>          buffer.append(name);
>          buffer.append('=');
>          buffer.append(quote(value));