Re: Bug: gnu.mail.util.QPOutputStream encodes linebreaks

Chris Burdess <[email protected]> Wed, 30 Aug 2006 15:10:56 +0100
Newsgroups gmane.comp.java.classpath.extensions.javamail
Message-ID <[email protected]>
Andy Wu wrote:
> False alarm. Turns out I had an old version of the class which I'd 
> updated manually but missed a vital change in 1.4.

OK, good to hear it.

> 
> Andy
> 
> Chris Burdess wrote:
> >Andy Wu wrote:
> >>I believe I've found a bug in the QPOutputStream code. When it comes 
> >>across a line break both "\r\n" and "=0D=0A" are being output 
> >>resulting in extraneous new lines.
> >>
> >>The fault appears to lie in the write( int b ) method. If b=='\r' or 
> >>b=='\n' the last if block should be avoided as the outputCRLF() will 
> >>have already done what's required.
> >
> >Hi Andy,
> >
> >If you could submit a patch, preferably with a small test case that 
> >demonstrates the problem and passes with the patch, it would be much 
> >appreciated.
-- 
Chris Burdess