Re: Patch Review: unused local variables

Chris Burdess <[email protected]> Thu, 29 Nov 2007 09:00:07 +0000

Newsgroups	gmane.comp.java.classpath.extensions.javamail
Message-ID	<[email protected]>

Conrad T. Pino wrote:
> Patch goals:
> 
> 1. Remove local variable is never read warnings, 32 in total.
> 
> Note: IMAPFolder retains "s.getConnection()" method call
>       to preserve state change side effects, if any.

Yes, there are side effects. The patch seems fine.
-- 
Chris Burdess