Re: Patch Review: source/javax/mail/FetchProfile.java

Chris Burdess <[email protected]> Thu, 29 Nov 2007 09:04:41 +0000
Newsgroups gmane.comp.java.classpath.extensions.javamail
Message-ID <[email protected]>
Conrad T. Pino wrote:
> Patch goal:
> 
> 1. Remove field FetchProfile.Item.name is never read locally
>    warnings, 57 in total.
> 
> Java 5 has @SuppressWarnings annotation but only if source level
> is so set requiring make system to detect compiler version & act
> accordingly.  Probably fails with older compilers.
> 
> The following patch adds a protected method to return the field
> and is noted as a non JavaMail API function.
> 
> Another alternative is override "toString()" to "return name;"
> but that's not in JavaMail API either.

No, we must preserve API compatibility with the published JavaMail API,
we can't add new public/protected methods.
-- 
Chris Burdess