Re: Unwanted SAXParseException

Ito Kazumitsu <[email protected]>
Newsgroups gmane.comp.java.classpath.extensions.xml,gmane.comp.java.vm.kaffe.general
Message-ID <[email protected]>
>>>>> ":" == David Brownell <[email protected]> writes:

:> You didn't see that warning though, right?  Odd.  And you didn't
:> see it _after_ applying your patch either either.

Well,

P1:  The patch to gnu/xml/aelfred2/SAXDriver.java
     dated Sat Oct 18 08:43:42 2003

P2:  The patch to gnu/xml/aelfred2/XmlParser.java
     dated Sun Oct 19 10:07:50 2003

W1:  "URI was not reported to parser for entity [dtd]"
     from gnu/xml/aelfred2/SAXDriver.java

W2:  "missing system ID, using test.dtd"
     from gnu/xml/aelfred2/XmlParser.java

P1  P2     W1  W2
--- ---    --- ---
No  No     Yes Yes
Yes No     No  No
No  Yes    Yes No

:> Guessing ids[1] seems wrong; rather than recording systemIdGuessed
:> as in your patch, I'd just remove the assignment.  And the test,
:> and the warning, since the SAXDriver should handle that (see my
:> response to Nic).

So here is another patch:

bash-2.05b$ diff -u gnu/xml/aelfred2/XmlParser.java.orig gnu/xml/aelfred2/XmlParser.java
--- gnu/xml/aelfred2/XmlParser.java.orig	Sun Sep 14 07:32:02 2003
+++ gnu/xml/aelfred2/XmlParser.java	Tue Oct 21 00:52:17 2003
@@ -3449,10 +3449,12 @@
 
 	    // we might be using alternate IDs/encoding
 	    systemId = source.getSystemId ();
+	    /*   systemId may be null but we should not make a guess
 	    if (systemId == null) {
 		handler.warn ("missing system ID, using " + ids [1]);
 		systemId = ids [1];
 	    }
+	    */
 	} else {
 	    // "[document]", or "[dtd]" via getExternalSubset()
 	    scratch.setCharacterStream (reader);
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.