[JIRA] Commented: (CC-991) Piping STDOUT->STDIN of scripts (piped exec builder)

    [ http://jira.public.thoughtworks.org/browse/CC-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_18924 ] 

Daniel Tihelka commented on CC-991:
-----------------------------------

Hmmm, I don't understant. I did build before submitting the patch (which was some time ago and many files may be changed since ...). However, I have tried to check out the fresh copy of the repository and apply the patch, and it seems OK to me:

dtihelka@uk508n03-kky ~/Pokusy/CC.smazat/cruisecontrol $ svn info .
Path: .
URL: https://cruisecontrol.svn.sourceforge.net/svnroot/cruisecontrol/trunk/cruisecontrol
Repository Root: https://cruisecontrol.svn.sourceforge.net/svnroot/cruisecontrol
Repository UUID: 878de816-9c12-0410-b5fe-b34e1928e20d
Revision: 4562
Node Kind: directory
Schedule: normal
Last Changed Author: jfredrick
Last Changed Rev: 4562
Last Changed Date: 2010-10-30 20:07:50 +0200 (So, 30 říj 2010)

dtihelka@uk508n03-kky ~/Pokusy/CC.smazat/cruisecontrol $ patch -p0 < ../PipedExecBuilder_09.patch
patching file main/test/net/sourceforge/cruisecontrol/testutil/SysUtilMock.java
patching file main/test/net/sourceforge/cruisecontrol/builders/PipedExecBuilderTest.java
patching file main/test/net/sourceforge/cruisecontrol/util/StdoutBufferTest.java
patching file main/test/net/sourceforge/cruisecontrol/util/charlist.utf8.txt
patching file main/src/net/sourceforge/cruisecontrol/builders/PipedExecBuilder.java
patching file main/src/net/sourceforge/cruisecontrol/util/StdoutBuffer.java

If you want, I can sent the output of ant, which seems to be OK as well (regarding the new classes) ... There is just a part of it:

....
compile:
--test-unit-compile:
    [javac] Compiling 210 source files to /home/dtihelka/Pokusy/CC.smazat/cruisecontrol/main/target/test-classes
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
--test-unit-copy-resources:
     [copy] Copying 76 files to /home/dtihelka/Pokusy/CC.smazat/cruisecontrol/main/target/test-classes
...
    [junit]
    [junit] Running net.sourceforge.cruisecontrol.builders.PipedExecBuilderTest
    [junit] Testsuite: net.sourceforge.cruisecontrol.builders.PipedExecBuilderTest
    [junit] Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 25,3 sec
    [junit] Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 25,3 sec
    [junit]
...

Please write, if I overlooked something ...


Synchronization:
It was simplified little bit, as the only variable which can be accessed simultaneously is 'buffer' (well, expecting that each particular instance of Input/Output stream will be accessed from one thread only, which is OK, I think). Is it more clear or should I explain it in more details?


> Piping STDOUT->STDIN of scripts (piped exec builder)
> ----------------------------------------------------
>
>                 Key: CC-991
>                 URL: http://jira.public.thoughtworks.org/browse/CC-991
>             Project: CruiseControl
>          Issue Type: New Feature
>          Components: Core Application
>         Environment: Any
>            Reporter: Daniel Tihelka
>         Assigned To: Dan Rollo
>         Attachments: Documentation.patch01, PipedExecBuilder-07_1.patch, PipedExecBuilder.java, PipedExecBuilder.patch01, PipedExecBuilder.patch02, PipedExecBuilder.patch03, PipedExecBuilder.patch04, PipedExecBuilder.patch05, PipedExecBuilder.patch06, PipedExecBuilder.patch07, PipedExecBuilder_08.patch, PipedExecBuilder_09.patch, PipedExecBuilderTest.java, StdoutBuffer.java, StdoutBufferTest.java
>
>   Original Estimate: 2 weeks
>  Remaining Estimate: 2 weeks
>
> The build process may sometime consist of the set of scripts piped one into another (the unix-way of filtering). This issue targets CruiseControl extension which would allow it.
> Almost a year ago, I have created PipedExecBuilder class as 3rd party CC plugin. It contains several scripts to execute, while the output of any script can be piped into the input of an arbitrary number of other scripts. Moreover, the execution of a script may be hold until another script is running (to prevent several scripts with large memory requirements running at the same time).
> The configuration may look as follows:
> <schedule>
>    <pipedexec>
>      <exec id="" command="" args="" />
>      <exec id="" command="" args="" pipefrom="" />
>      <exec id="" command="" args="" waitfor="" />
>      <exec id="" command="" args="" pipefrom="" waitfor="" />
>    </pipedexec>
> </schedule>
> where the <exec /> tag is the same as the original <exec /> tag, with additional attributes:
> - id - unique identifier of the script for the piping
> - pipefrom - the id of script from which to pipe stdout into the stdin of the current script (optional)
> - waitfor - the id of script to wait for - it holds the execution of the current script until the script which we wait for terminates.
> The pipedexec builder tries to run as many scripts in parallel as possible, while it finishes when all the scripts were finished, or when a script failed.
> For further details see cruisecontrol-devel mailing list thread:
> http://sourceforge.net/mailarchive/forum.php?thread_name=201005271341.32553.dtihelka%40kky.zcu.cz&forum_name=cruisecontrol-devel
> Kind regards,
> DanT

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.public.thoughtworks.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Cruisecontrol-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cruisecontrol-devel